* [PATCH] mtd: spi-nor: issi: Add support for is25wx01g
@ 2025-09-01 16:42 Flaviu Nistor
2025-09-01 17:13 ` Pratyush Yadav
0 siblings, 1 reply; 3+ messages in thread
From: Flaviu Nistor @ 2025-09-01 16:42 UTC (permalink / raw)
To: Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra
Cc: linux-mtd, linux-kernel, flaviu.nistor
Add support for the IS25WX01G 128MB (1Gb) ISSI Serial Flash Memory.
Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
---
drivers/mtd/spi-nor/issi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c
index 18d9a00aa22e..e4997f9bd557 100644
--- a/drivers/mtd/spi-nor/issi.c
+++ b/drivers/mtd/spi-nor/issi.c
@@ -126,6 +126,9 @@ static const struct flash_info issi_nor_parts[] = {
.flags = SPI_NOR_QUAD_PP,
.fixups = &is25lp256_fixups,
.fixup_flags = SPI_NOR_4B_OPCODES,
+ }, {
+ /* IS25WX01G */
+ .id = SNOR_ID(0x9d, 0x5b, 0x1b),
}
};
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: spi-nor: issi: Add support for is25wx01g
2025-09-01 16:42 [PATCH] mtd: spi-nor: issi: Add support for is25wx01g Flaviu Nistor
@ 2025-09-01 17:13 ` Pratyush Yadav
2025-09-02 18:38 ` Flaviu Nistor
0 siblings, 1 reply; 3+ messages in thread
From: Pratyush Yadav @ 2025-09-01 17:13 UTC (permalink / raw)
To: Flaviu Nistor
Cc: Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, linux-kernel
Hi Flaviu,
On Mon, Sep 01 2025, Flaviu Nistor wrote:
> Add support for the IS25WX01G 128MB (1Gb) ISSI Serial Flash Memory.
>
> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
> ---
> drivers/mtd/spi-nor/issi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c
> index 18d9a00aa22e..e4997f9bd557 100644
> --- a/drivers/mtd/spi-nor/issi.c
> +++ b/drivers/mtd/spi-nor/issi.c
> @@ -126,6 +126,9 @@ static const struct flash_info issi_nor_parts[] = {
> .flags = SPI_NOR_QUAD_PP,
> .fixups = &is25lp256_fixups,
> .fixup_flags = SPI_NOR_4B_OPCODES,
> + }, {
> + /* IS25WX01G */
> + .id = SNOR_ID(0x9d, 0x5b, 0x1b),
It seems the flash needs no special configuration. IIUC it can be driven
entirely based on SFDP data. In that case, I don't think there is a need
for an entry at all. The generic SFDP-based driver should already be
enough for your flash. Just add a "jedec,spi-nor" node to your DT and it
should work.
> }
> };
--
Regards,
Pratyush Yadav
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: spi-nor: issi: Add support for is25wx01g
2025-09-01 17:13 ` Pratyush Yadav
@ 2025-09-02 18:38 ` Flaviu Nistor
0 siblings, 0 replies; 3+ messages in thread
From: Flaviu Nistor @ 2025-09-02 18:38 UTC (permalink / raw)
To: Pratyush Yadav
Cc: Tudor Ambarus, Michael Walle, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-mtd, linux-kernel, flaviu.nistor
> Hi Flaviu,
>
> On Mon, Sep 01 2025, Flaviu Nistor wrote:
>
>> Add support for the IS25WX01G 128MB (1Gb) ISSI Serial Flash Memory.
>>
>> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
>> ---
>> drivers/mtd/spi-nor/issi.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/mtd/spi-nor/issi.c b/drivers/mtd/spi-nor/issi.c
>> index 18d9a00aa22e..e4997f9bd557 100644
>> --- a/drivers/mtd/spi-nor/issi.c
>> +++ b/drivers/mtd/spi-nor/issi.c
>> @@ -126,6 +126,9 @@ static const struct flash_info issi_nor_parts[] = {
>> .flags = SPI_NOR_QUAD_PP,
>> .fixups = &is25lp256_fixups,
>> .fixup_flags = SPI_NOR_4B_OPCODES,
>> + }, {
>> + /* IS25WX01G */
>> + .id = SNOR_ID(0x9d, 0x5b, 0x1b),
>
> It seems the flash needs no special configuration. IIUC it can be driven
> entirely based on SFDP data. In that case, I don't think there is a need
> for an entry at all. The generic SFDP-based driver should already be
> enough for your flash. Just add a "jedec,spi-nor" node to your DT and it
> should work.
Thanks for the review and the explanation. I now see in
the core driver that spi_nor_check_sfdp_signature() is
used if spi_nor_match_id() does not find a valid entry.
>
>> }
>> };
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-02 18:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-01 16:42 [PATCH] mtd: spi-nor: issi: Add support for is25wx01g Flaviu Nistor
2025-09-01 17:13 ` Pratyush Yadav
2025-09-02 18:38 ` Flaviu Nistor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).