linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 0/2] riscv: dts: starfive: jh7110-common: drop no-mmc and power-on-delay-ms from mmc interfaces
@ 2025-09-03 10:13 E Shattow
  2025-09-03 10:13 ` [PATCH v1 1/2] riscv: dts: starfive: jh7110-common: drop no-mmc property from mmc1 E Shattow
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: E Shattow @ 2025-09-03 10:13 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti
  Cc: linux-kernel, linux-riscv, devicetree, E Shattow

Drop no-mmc and power-on-delay-ms properties.

The committer cannot be reached for comment and per discussion [1] and
testing there is not any observable problem that is being solved by
having these properties for the VisionFive 2 or similar variant boards
through the jh7110-common.dtsi include.

E Shattow (2):
  riscv: dts: starfive: jh7110-common: drop no-mmc property from mmc1
  riscv: dts: starfive: jh7110-common: drop mmc post-power-on-delay-ms

 arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 3 ---
 1 file changed, 3 deletions(-)


base-commit: f66eb149b87677da3171a0ed51c77c3599ad55d6
-- 
2.50.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v1 1/2] riscv: dts: starfive: jh7110-common: drop no-mmc property from mmc1
  2025-09-03 10:13 [PATCH v1 0/2] riscv: dts: starfive: jh7110-common: drop no-mmc and power-on-delay-ms from mmc interfaces E Shattow
@ 2025-09-03 10:13 ` E Shattow
  2025-09-03 10:13 ` [PATCH v1 2/2] riscv: dts: starfive: jh7110-common: drop mmc post-power-on-delay-ms E Shattow
  2025-09-03 10:19 ` [PATCH v1 0/2] riscv: dts: starfive: jh7110-common: drop no-mmc and power-on-delay-ms from mmc interfaces E Shattow
  2 siblings, 0 replies; 4+ messages in thread
From: E Shattow @ 2025-09-03 10:13 UTC (permalink / raw)
  To: Conor Dooley, Emil Renner Berthing, Rob Herring,
	Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
	Alexandre Ghiti
  Cc: linux-kernel, linux-riscv, devicetree, E Shattow, Hal Feng

Relax no-mmc restriction on mmc1 for jh7110 boards. The restriction is
only needed to block use of commands that would cause a device to
malfunction, which by testing and observation [1] is not any problem.

1: https://lore.kernel.org/lkml/NT0PR01MB1312E0D9EE9F158A57B77700E63D2@NT0PR01MB1312.CHNPR01.prod.partner.outlook.cn/

Signed-off-by: E Shattow <e@freeshell.de>
Tested-by: Hal Feng <hal.feng@starfivetech.com>
---
 arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
index a315113840e5..4fa77ffd54e3 100644
--- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
+++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
@@ -299,7 +299,6 @@ &mmc1 {
 	assigned-clock-rates = <50000000>;
 	bus-width = <4>;
 	bootph-pre-ram;
-	no-mmc;
 	cd-gpios = <&sysgpio 41 GPIO_ACTIVE_LOW>;
 	disable-wp;
 	cap-sd-highspeed;
-- 
2.50.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v1 2/2] riscv: dts: starfive: jh7110-common: drop mmc post-power-on-delay-ms
  2025-09-03 10:13 [PATCH v1 0/2] riscv: dts: starfive: jh7110-common: drop no-mmc and power-on-delay-ms from mmc interfaces E Shattow
  2025-09-03 10:13 ` [PATCH v1 1/2] riscv: dts: starfive: jh7110-common: drop no-mmc property from mmc1 E Shattow
@ 2025-09-03 10:13 ` E Shattow
  2025-09-03 10:19 ` [PATCH v1 0/2] riscv: dts: starfive: jh7110-common: drop no-mmc and power-on-delay-ms from mmc interfaces E Shattow
  2 siblings, 0 replies; 4+ messages in thread
From: E Shattow @ 2025-09-03 10:13 UTC (permalink / raw)
  To: Conor Dooley, Emil Renner Berthing, Rob Herring,
	Krzysztof Kozlowski, Paul Walmsley, Palmer Dabbelt, Albert Ou,
	Alexandre Ghiti
  Cc: linux-kernel, linux-riscv, devicetree, E Shattow, Hal Feng

Drop post-power-on-delay-ms from mmc0 mmc1 interfaces. There is no
known reason for these properties to continue, testing appears to be fine
without them [1].

1: https://lore.kernel.org/lkml/NT0PR01MB1312E0D9EE9F158A57B77700E63D2@NT0PR01MB1312.CHNPR01.prod.partner.outlook.cn/

Signed-off-by: E Shattow <e@freeshell.de>
Tested-by: Hal Feng <hal.feng@starfivetech.com>
---
 arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
index 4fa77ffd54e3..5dc15e48b74b 100644
--- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
+++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
@@ -285,7 +285,6 @@ &mmc0 {
 	mmc-ddr-1_8v;
 	mmc-hs200-1_8v;
 	cap-mmc-hw-reset;
-	post-power-on-delay-ms = <200>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc0_pins>;
 	vmmc-supply = <&vcc_3v3>;
@@ -302,7 +301,6 @@ &mmc1 {
 	cd-gpios = <&sysgpio 41 GPIO_ACTIVE_LOW>;
 	disable-wp;
 	cap-sd-highspeed;
-	post-power-on-delay-ms = <200>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc1_pins>;
 	status = "okay";
-- 
2.50.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 0/2] riscv: dts: starfive: jh7110-common: drop no-mmc and power-on-delay-ms from mmc interfaces
  2025-09-03 10:13 [PATCH v1 0/2] riscv: dts: starfive: jh7110-common: drop no-mmc and power-on-delay-ms from mmc interfaces E Shattow
  2025-09-03 10:13 ` [PATCH v1 1/2] riscv: dts: starfive: jh7110-common: drop no-mmc property from mmc1 E Shattow
  2025-09-03 10:13 ` [PATCH v1 2/2] riscv: dts: starfive: jh7110-common: drop mmc post-power-on-delay-ms E Shattow
@ 2025-09-03 10:19 ` E Shattow
  2 siblings, 0 replies; 4+ messages in thread
From: E Shattow @ 2025-09-03 10:19 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti
  Cc: linux-kernel, linux-riscv, devicetree


On 9/3/25 03:13, E Shattow wrote:
> Drop no-mmc and power-on-delay-ms properties.
> 
> The committer cannot be reached for comment and per discussion [1] and
> testing there is not any observable problem that is being solved by
> having these properties for the VisionFive 2 or similar variant boards
> through the jh7110-common.dtsi include.
> 
> E Shattow (2):
>   riscv: dts: starfive: jh7110-common: drop no-mmc property from mmc1
>   riscv: dts: starfive: jh7110-common: drop mmc post-power-on-delay-ms
> 
>  arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 3 ---
>  1 file changed, 3 deletions(-)
> 
> 
> base-commit: f66eb149b87677da3171a0ed51c77c3599ad55d6

P.S. missed the URL for reference [1] in this cover letter. It is:

1:
https://lore.kernel.org/lkml/NT0PR01MB1312E0D9EE9F158A57B77700E63D2@NT0PR01MB1312.CHNPR01.prod.partner.outlook.cn/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-09-03 10:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-03 10:13 [PATCH v1 0/2] riscv: dts: starfive: jh7110-common: drop no-mmc and power-on-delay-ms from mmc interfaces E Shattow
2025-09-03 10:13 ` [PATCH v1 1/2] riscv: dts: starfive: jh7110-common: drop no-mmc property from mmc1 E Shattow
2025-09-03 10:13 ` [PATCH v1 2/2] riscv: dts: starfive: jh7110-common: drop mmc post-power-on-delay-ms E Shattow
2025-09-03 10:19 ` [PATCH v1 0/2] riscv: dts: starfive: jh7110-common: drop no-mmc and power-on-delay-ms from mmc interfaces E Shattow

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).