* [PATCH] pinctrl: spacemit: fix typo in PRI_TDI pin name
@ 2025-09-03 10:01 Hendrik Hamerlinck
2025-09-03 10:18 ` Yixun Lan
0 siblings, 1 reply; 2+ messages in thread
From: Hendrik Hamerlinck @ 2025-09-03 10:01 UTC (permalink / raw)
To: linus.walleij, dlan
Cc: skhan, linux-kernel-mentees, linux-gpio, linux-riscv, spacemit,
linux-kernel, Hendrik Hamerlinck
The datasheet lists this signal as PRI_TDI, not PRI_DTI.
Fix the pin name to match the documentation and JTAG naming
convention (TDI = Test Data In).
Signed-off-by: Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>
---
drivers/pinctrl/spacemit/pinctrl-k1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/spacemit/pinctrl-k1.c b/drivers/pinctrl/spacemit/pinctrl-k1.c
index 9996b1c4a07e..a3f433b611f7 100644
--- a/drivers/pinctrl/spacemit/pinctrl-k1.c
+++ b/drivers/pinctrl/spacemit/pinctrl-k1.c
@@ -847,7 +847,7 @@ static const struct pinctrl_pin_desc k1_pin_desc[] = {
PINCTRL_PIN(67, "GPIO_67"),
PINCTRL_PIN(68, "GPIO_68"),
PINCTRL_PIN(69, "GPIO_69"),
- PINCTRL_PIN(70, "GPIO_70/PRI_DTI"),
+ PINCTRL_PIN(70, "GPIO_70/PRI_TDI"),
PINCTRL_PIN(71, "GPIO_71/PRI_TMS"),
PINCTRL_PIN(72, "GPIO_72/PRI_TCK"),
PINCTRL_PIN(73, "GPIO_73/PRI_TDO"),
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: spacemit: fix typo in PRI_TDI pin name
2025-09-03 10:01 [PATCH] pinctrl: spacemit: fix typo in PRI_TDI pin name Hendrik Hamerlinck
@ 2025-09-03 10:18 ` Yixun Lan
0 siblings, 0 replies; 2+ messages in thread
From: Yixun Lan @ 2025-09-03 10:18 UTC (permalink / raw)
To: Hendrik Hamerlinck
Cc: linus.walleij, skhan, linux-kernel-mentees, linux-gpio,
linux-riscv, spacemit, linux-kernel
Hi Hendrik,
On 12:01 Wed 03 Sep , Hendrik Hamerlinck wrote:
> The datasheet lists this signal as PRI_TDI, not PRI_DTI.
> Fix the pin name to match the documentation and JTAG naming
> convention (TDI = Test Data In).
>
> Signed-off-by: Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>
Reviewed-by: Yixun Lan <dlan@gentoo.org>
> ---
> drivers/pinctrl/spacemit/pinctrl-k1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/spacemit/pinctrl-k1.c b/drivers/pinctrl/spacemit/pinctrl-k1.c
> index 9996b1c4a07e..a3f433b611f7 100644
> --- a/drivers/pinctrl/spacemit/pinctrl-k1.c
> +++ b/drivers/pinctrl/spacemit/pinctrl-k1.c
> @@ -847,7 +847,7 @@ static const struct pinctrl_pin_desc k1_pin_desc[] = {
> PINCTRL_PIN(67, "GPIO_67"),
> PINCTRL_PIN(68, "GPIO_68"),
> PINCTRL_PIN(69, "GPIO_69"),
> - PINCTRL_PIN(70, "GPIO_70/PRI_DTI"),
> + PINCTRL_PIN(70, "GPIO_70/PRI_TDI"),
> PINCTRL_PIN(71, "GPIO_71/PRI_TMS"),
> PINCTRL_PIN(72, "GPIO_72/PRI_TCK"),
> PINCTRL_PIN(73, "GPIO_73/PRI_TDO"),
> --
> 2.43.0
>
--
Yixun Lan (dlan)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-03 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-03 10:01 [PATCH] pinctrl: spacemit: fix typo in PRI_TDI pin name Hendrik Hamerlinck
2025-09-03 10:18 ` Yixun Lan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).