Re: [PATCH] media: uvcvideo: Shorten the transfer size non compliance message

Laurent Pinchart
2025-09-08T08:36:08Z

On Thu, Sep 04, 2025 at 10:24:05AM +0200, Michal Pecio wrote:
> On Thu, 4 Sep 2025 09:20:31 +0200, Ricardo Ribalda wrote:
> > Hi Michal
> >
> > I like the new writing :)
> >
> > On Thu, 4 Sept 2025 at 08:14, Michal Pecio <michal.pecio@gmail.com> wrote:
> > >
> > > This message is much longer than others and doesn't fit even in a 160
> > > column window when printed, despite providing little real information.
> > >
> > > Also replace 'transmission' with 'transfer' because that's the actual
> > > name and 'max packet' with 'limit' because it isn't same thing with
> > > isochronus endpoints. Remove cryptic abbreviations like 'ep'.
> > >
> > Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
>
> Thank you.
>
> On second thought, I'm not sure if those brackets look good here:
>
> [ 2410.688715] uvcvideo 11-1:1.1: UVC non compliance: Reducing max payload transfer size (32764) to fit endpoint limit (20480).
>
> but I sent the patch already. If you think it would be better without
> them, please feel free to tweak the patch or ask for v2. If not, meh.

I like th enew message.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

--
Regards,

Laurent Pinchart