* [PATCH 1/1] dt-bindings: rtc: pcf2127: add compatible string nxp,rtc-pcf2123 @ 2025-09-03 16:55 Frank Li 2025-09-03 16:58 ` Alexandre Belloni 0 siblings, 1 reply; 7+ messages in thread From: Frank Li @ 2025-09-03 16:55 UTC (permalink / raw) To: Alexandre Belloni, Rob Herring, Krzysztof Kozlowski, Conor Dooley, open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list Cc: imx Add compatible string nxp,rtc-pcf2123, which style is not consistent with existed compatible string because existed driver and dts use nxp,rtc-pcf2123. Fix below CHECK_DTBS warning: arch/arm/boot/dts/nxp/imx/imx6q-evi.dtb: /soc/bus@2000000/spba-bus@2000000/spi@2018000/rtc@3: failed to match any schema with compatible: ['nxp,rtc-pcf2123'] Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml index 11fcf0ca1ae07..595c20df6a411 100644 --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml @@ -20,6 +20,7 @@ properties: - nxp,pcf2127 - nxp,pcf2129 - nxp,pcf2131 + - nxp,rtc-pcf2123 reg: maxItems: 1 -- 2.34.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: rtc: pcf2127: add compatible string nxp,rtc-pcf2123 2025-09-03 16:55 [PATCH 1/1] dt-bindings: rtc: pcf2127: add compatible string nxp,rtc-pcf2123 Frank Li @ 2025-09-03 16:58 ` Alexandre Belloni 2025-09-03 18:24 ` Frank Li 0 siblings, 1 reply; 7+ messages in thread From: Alexandre Belloni @ 2025-09-03 16:58 UTC (permalink / raw) To: Frank Li Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On 03/09/2025 12:55:36-0400, Frank Li wrote: > Add compatible string nxp,rtc-pcf2123, which style is not consistent with > existed compatible string because existed driver and dts use > nxp,rtc-pcf2123. > > Fix below CHECK_DTBS warning: > arch/arm/boot/dts/nxp/imx/imx6q-evi.dtb: /soc/bus@2000000/spba-bus@2000000/spi@2018000/rtc@3: failed to match any schema with compatible: ['nxp,rtc-pcf2123'] > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > index 11fcf0ca1ae07..595c20df6a411 100644 > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > @@ -20,6 +20,7 @@ properties: > - nxp,pcf2127 > - nxp,pcf2129 > - nxp,pcf2131 > + - nxp,rtc-pcf2123 Nope, you need to fix the devicetree. > > reg: > maxItems: 1 > -- > 2.34.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: rtc: pcf2127: add compatible string nxp,rtc-pcf2123 2025-09-03 16:58 ` Alexandre Belloni @ 2025-09-03 18:24 ` Frank Li 2025-09-03 19:24 ` Alexandre Belloni 0 siblings, 1 reply; 7+ messages in thread From: Frank Li @ 2025-09-03 18:24 UTC (permalink / raw) To: Alexandre Belloni Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Wed, Sep 03, 2025 at 06:58:29PM +0200, Alexandre Belloni wrote: > On 03/09/2025 12:55:36-0400, Frank Li wrote: > > Add compatible string nxp,rtc-pcf2123, which style is not consistent with > > existed compatible string because existed driver and dts use > > nxp,rtc-pcf2123. > > > > Fix below CHECK_DTBS warning: > > arch/arm/boot/dts/nxp/imx/imx6q-evi.dtb: /soc/bus@2000000/spba-bus@2000000/spi@2018000/rtc@3: failed to match any schema with compatible: ['nxp,rtc-pcf2123'] > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > index 11fcf0ca1ae07..595c20df6a411 100644 > > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > @@ -20,6 +20,7 @@ properties: > > - nxp,pcf2127 > > - nxp,pcf2129 > > - nxp,pcf2131 > > + - nxp,rtc-pcf2123 > > Nope, you need to fix the devicetree. Oh, driver drivers/rtc/rtc-pcf2123.c also use nxp,rtc-pcf2123. For such old devices, generally keep it as it. Maybe DT team members provide more professional comments for it. Frank > > > > > reg: > > maxItems: 1 > > -- > > 2.34.1 > > > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: rtc: pcf2127: add compatible string nxp,rtc-pcf2123 2025-09-03 18:24 ` Frank Li @ 2025-09-03 19:24 ` Alexandre Belloni 2025-09-04 9:29 ` Krzysztof Kozlowski 0 siblings, 1 reply; 7+ messages in thread From: Alexandre Belloni @ 2025-09-03 19:24 UTC (permalink / raw) To: Frank Li Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On 03/09/2025 14:24:10-0400, Frank Li wrote: > On Wed, Sep 03, 2025 at 06:58:29PM +0200, Alexandre Belloni wrote: > > On 03/09/2025 12:55:36-0400, Frank Li wrote: > > > Add compatible string nxp,rtc-pcf2123, which style is not consistent with > > > existed compatible string because existed driver and dts use > > > nxp,rtc-pcf2123. > > > > > > Fix below CHECK_DTBS warning: > > > arch/arm/boot/dts/nxp/imx/imx6q-evi.dtb: /soc/bus@2000000/spba-bus@2000000/spi@2018000/rtc@3: failed to match any schema with compatible: ['nxp,rtc-pcf2123'] > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > --- > > > Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > > index 11fcf0ca1ae07..595c20df6a411 100644 > > > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > > @@ -20,6 +20,7 @@ properties: > > > - nxp,pcf2127 > > > - nxp,pcf2129 > > > - nxp,pcf2131 > > > + - nxp,rtc-pcf2123 > > > > Nope, you need to fix the devicetree. > > Oh, driver drivers/rtc/rtc-pcf2123.c also use nxp,rtc-pcf2123. For such old > devices, generally keep it as it. > > Maybe DT team members provide more professional comments for it. It is there for DT ABI compatibility, we don't need to advertise its existence in the doc, you must fix the device tree. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: rtc: pcf2127: add compatible string nxp,rtc-pcf2123 2025-09-03 19:24 ` Alexandre Belloni @ 2025-09-04 9:29 ` Krzysztof Kozlowski 2025-09-04 12:06 ` Alexandre Belloni 0 siblings, 1 reply; 7+ messages in thread From: Krzysztof Kozlowski @ 2025-09-04 9:29 UTC (permalink / raw) To: Alexandre Belloni Cc: Frank Li, Rob Herring, Krzysztof Kozlowski, Conor Dooley, open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On Wed, Sep 03, 2025 at 09:24:36PM +0200, Alexandre Belloni wrote: > On 03/09/2025 14:24:10-0400, Frank Li wrote: > > On Wed, Sep 03, 2025 at 06:58:29PM +0200, Alexandre Belloni wrote: > > > On 03/09/2025 12:55:36-0400, Frank Li wrote: > > > > Add compatible string nxp,rtc-pcf2123, which style is not consistent with > > > > existed compatible string because existed driver and dts use > > > > nxp,rtc-pcf2123. > > > > > > > > Fix below CHECK_DTBS warning: > > > > arch/arm/boot/dts/nxp/imx/imx6q-evi.dtb: /soc/bus@2000000/spba-bus@2000000/spi@2018000/rtc@3: failed to match any schema with compatible: ['nxp,rtc-pcf2123'] > > > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > > --- > > > > Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > > > index 11fcf0ca1ae07..595c20df6a411 100644 > > > > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > > > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > > > @@ -20,6 +20,7 @@ properties: > > > > - nxp,pcf2127 > > > > - nxp,pcf2129 > > > > - nxp,pcf2131 > > > > + - nxp,rtc-pcf2123 > > > > > > Nope, you need to fix the devicetree. Yep, 6 years is enough for all users to adjust, so I agree. > > > > Oh, driver drivers/rtc/rtc-pcf2123.c also use nxp,rtc-pcf2123. For such old > > devices, generally keep it as it. > > > > Maybe DT team members provide more professional comments for it. > > It is there for DT ABI compatibility, we don't need to advertise its > existence in the doc, you must fix the device tree. In-tree compatibles should be documented anyway (as "deprecated: true"). Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: rtc: pcf2127: add compatible string nxp,rtc-pcf2123 2025-09-04 9:29 ` Krzysztof Kozlowski @ 2025-09-04 12:06 ` Alexandre Belloni 2025-09-04 13:09 ` Krzysztof Kozlowski 0 siblings, 1 reply; 7+ messages in thread From: Alexandre Belloni @ 2025-09-04 12:06 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Frank Li, Rob Herring, Krzysztof Kozlowski, Conor Dooley, open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On 04/09/2025 11:29:25+0200, Krzysztof Kozlowski wrote: > On Wed, Sep 03, 2025 at 09:24:36PM +0200, Alexandre Belloni wrote: > > On 03/09/2025 14:24:10-0400, Frank Li wrote: > > > On Wed, Sep 03, 2025 at 06:58:29PM +0200, Alexandre Belloni wrote: > > > > On 03/09/2025 12:55:36-0400, Frank Li wrote: > > > > > Add compatible string nxp,rtc-pcf2123, which style is not consistent with > > > > > existed compatible string because existed driver and dts use > > > > > nxp,rtc-pcf2123. > > > > > > > > > > Fix below CHECK_DTBS warning: > > > > > arch/arm/boot/dts/nxp/imx/imx6q-evi.dtb: /soc/bus@2000000/spba-bus@2000000/spi@2018000/rtc@3: failed to match any schema with compatible: ['nxp,rtc-pcf2123'] > > > > > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > > > --- > > > > > Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > > > > index 11fcf0ca1ae07..595c20df6a411 100644 > > > > > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > > > > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml > > > > > @@ -20,6 +20,7 @@ properties: > > > > > - nxp,pcf2127 > > > > > - nxp,pcf2129 > > > > > - nxp,pcf2131 > > > > > + - nxp,rtc-pcf2123 > > > > > > > > Nope, you need to fix the devicetree. > > Yep, 6 years is enough for all users to adjust, so I agree. > > > > > > > Oh, driver drivers/rtc/rtc-pcf2123.c also use nxp,rtc-pcf2123. For such old > > > devices, generally keep it as it. > > > > > > Maybe DT team members provide more professional comments for it. > > > > It is there for DT ABI compatibility, we don't need to advertise its > > existence in the doc, you must fix the device tree. > > In-tree compatibles should be documented anyway (as "deprecated: true"). > There is one device tree to fix, then we won't have any occurrence in-tree anymore. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] dt-bindings: rtc: pcf2127: add compatible string nxp,rtc-pcf2123 2025-09-04 12:06 ` Alexandre Belloni @ 2025-09-04 13:09 ` Krzysztof Kozlowski 0 siblings, 0 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2025-09-04 13:09 UTC (permalink / raw) To: Alexandre Belloni Cc: Frank Li, Rob Herring, Krzysztof Kozlowski, Conor Dooley, open list:REAL TIME CLOCK (RTC) SUBSYSTEM, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list, imx On 04/09/2025 14:06, Alexandre Belloni wrote: >>>> >>>> Oh, driver drivers/rtc/rtc-pcf2123.c also use nxp,rtc-pcf2123. For such old >>>> devices, generally keep it as it. >>>> >>>> Maybe DT team members provide more professional comments for it. >>> >>> It is there for DT ABI compatibility, we don't need to advertise its >>> existence in the doc, you must fix the device tree. >> >> In-tree compatibles should be documented anyway (as "deprecated: true"). >> > > There is one device tree to fix, then we won't have any occurrence > in-tree anymore. The driver is, unless there is patch dropping it somewhere... Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-09-04 13:09 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-09-03 16:55 [PATCH 1/1] dt-bindings: rtc: pcf2127: add compatible string nxp,rtc-pcf2123 Frank Li 2025-09-03 16:58 ` Alexandre Belloni 2025-09-03 18:24 ` Frank Li 2025-09-03 19:24 ` Alexandre Belloni 2025-09-04 9:29 ` Krzysztof Kozlowski 2025-09-04 12:06 ` Alexandre Belloni 2025-09-04 13:09 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).