From: Leo Yan <leo.yan@arm.com>
To: James Clark <james.clark@linaro.org>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Tamas Zsoldos <tamas.zsoldos@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH] coresight: perf: Fix pointer check with IS_ERR_OR_NULL()
Date: Thu, 4 Sep 2025 14:02:48 +0100 [thread overview]
Message-ID: <20250904130248.GO745921@e132581.arm.com> (raw)
In-Reply-To: <20cec516-1589-4fc5-ac07-06029f2dc143@linaro.org>
On Thu, Sep 04, 2025 at 01:11:37PM +0100, James Clark wrote:
[...]
> > I think the bug is in TRBE. It's the only one that returns an error
> > pointer, but only for -ENOMEM which would normally be NULL for alloc
> > type functions anyway.
Thought again, you are right — it is better to fix this in TRBE, since
we don't really get any benefit from an artificial "-ENOMEM".
Will respin a new one.
Thanks,
Leo
prev parent reply other threads:[~2025-09-04 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 10:53 [PATCH] coresight: perf: Fix pointer check with IS_ERR_OR_NULL() Leo Yan
2025-09-04 12:00 ` James Clark
2025-09-04 12:11 ` James Clark
2025-09-04 13:02 ` Leo Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904130248.GO745921@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.clark@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=tamas.zsoldos@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox