The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Michael Jeanson <mjeanson@efficios.com>,
	Jens Axboe <axboe@kernel.dk>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>,
	Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
	x86@kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Heiko Carstens <hca@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Huacai Chen <chenhuacai@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>
Subject: [patch V3 22/37] rseq: Use static branch for syscall exit debug when GENERIC_IRQ_ENTRY=y
Date: Fri,  5 Sep 2025 00:21:15 +0200 (CEST)	[thread overview]
Message-ID: <20250904185720.526220243@linutronix.de> (raw)
In-Reply-To: 20250904185336.943880027@linutronix.de

Make the syscall exit debug mechanism available via the static branch on
architectures which utilize the generic entry code.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

---
 include/linux/entry-common.h |    2 +-
 include/linux/rseq_entry.h   |    9 +++++++++
 kernel/rseq.c                |   19 +++++++++++++------
 3 files changed, 23 insertions(+), 7 deletions(-)

--- a/include/linux/entry-common.h
+++ b/include/linux/entry-common.h
@@ -146,7 +146,7 @@ static __always_inline void syscall_exit
 			local_irq_enable();
 	}
 
-	rseq_syscall(regs);
+	rseq_debug_syscall_return(regs);
 
 	/*
 	 * Do one-time syscall specific work. If these work items are
--- a/include/linux/rseq_entry.h
+++ b/include/linux/rseq_entry.h
@@ -286,9 +286,18 @@ static __always_inline void rseq_exit_to
 	ev->events = 0;
 }
 
+void __rseq_debug_syscall_return(struct pt_regs *regs);
+
+static inline void rseq_debug_syscall_return(struct pt_regs *regs)
+{
+	if (static_branch_unlikely(&rseq_debug_enabled))
+		__rseq_debug_syscall_return(regs);
+}
+
 #else /* CONFIG_RSEQ */
 static inline void rseq_note_user_irq_entry(void) { }
 static inline void rseq_exit_to_user_mode(void) { }
+static inline void rseq_debug_syscall_return(struct pt_regs *regs) { }
 #endif /* !CONFIG_RSEQ */
 
 #endif /* _LINUX_RSEQ_ENTRY_H */
--- a/kernel/rseq.c
+++ b/kernel/rseq.c
@@ -470,12 +470,7 @@ void __rseq_handle_notify_resume(struct
 	force_sigsegv(sig);
 }
 
-#ifdef CONFIG_DEBUG_RSEQ
-/*
- * Terminate the process if a syscall is issued within a restartable
- * sequence.
- */
-void rseq_syscall(struct pt_regs *regs)
+void __rseq_debug_syscall_return(struct pt_regs *regs)
 {
 	struct task_struct *t = current;
 	u64 csaddr;
@@ -493,6 +488,18 @@ void rseq_syscall(struct pt_regs *regs)
 fail:
 	force_sig(SIGSEGV);
 }
+
+#ifdef CONFIG_DEBUG_RSEQ
+/*
+ * Kept around to keep GENERIC_ENTRY=n architectures supported.
+ *
+ * Terminate the process if a syscall is issued within a restartable
+ * sequence.
+ */
+void rseq_syscall(struct pt_regs *regs)
+{
+	__rseq_debug_syscall_return(regs);
+}
 #endif
 
 /*




  parent reply	other threads:[~2025-09-04 22:21 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04 22:20 [patch V3 00/37] rseq: Optimize exit to user space Thomas Gleixner
2025-09-04 22:20 ` [patch V3 01/37] rseq: Avoid pointless evaluation in __rseq_notify_resume() Thomas Gleixner
2025-09-04 22:20 ` [patch V3 02/37] rseq: Condense the inline stubs Thomas Gleixner
2025-09-04 22:20 ` [patch V3 03/37] rseq: Move algorithm comment to top Thomas Gleixner
2025-09-04 22:20 ` [patch V3 04/37] rseq: Remove the ksig argument from rseq_handle_notify_resume() Thomas Gleixner
2025-09-04 22:20 ` [patch V3 05/37] rseq: Simplify registration Thomas Gleixner
2025-09-04 22:20 ` [patch V3 06/37] rseq: Simplify the event notification Thomas Gleixner
2025-09-04 22:20 ` [patch V3 07/37] rseq, virt: Retrigger RSEQ after vcpu_run() Thomas Gleixner
2025-09-04 22:20 ` [patch V3 08/37] rseq: Avoid CPU/MM CID updates when no event pending Thomas Gleixner
2025-09-04 22:20 ` [patch V3 09/37] rseq: Introduce struct rseq_event Thomas Gleixner
2025-09-04 22:20 ` [patch V3 10/37] entry: Cleanup header Thomas Gleixner
2025-09-04 22:20 ` [patch V3 11/37] entry: Remove syscall_enter_from_user_mode_prepare() Thomas Gleixner
2025-09-04 22:20 ` [patch V3 12/37] entry: Inline irqentry_enter/exit_from/to_user_mode() Thomas Gleixner
2025-09-04 22:20 ` [patch V3 13/37] sched: Move MM CID related functions to sched.h Thomas Gleixner
2025-09-04 22:21 ` [patch V3 14/37] rseq: Cache CPU ID and MM CID values Thomas Gleixner
2025-09-04 22:21 ` [patch V3 15/37] rseq: Record interrupt from user space Thomas Gleixner
2025-09-04 22:21 ` [patch V3 16/37] From: Thomas Gleixner <tglx@linutronix.de> 65;7006;1cSubject: rseq: Provide tracepoint wrappers for inline code Date: Sat, 23 Aug 2025 18:39:45 +0200 Thomas Gleixner
2025-09-04 22:37   ` Mathieu Desnoyers
2025-09-04 22:40   ` [patch V3 RESEND 16/37] rseq: Provide tracepoint wrappers for inline code Thomas Gleixner
2025-09-04 22:21 ` [patch V3 17/37] rseq: Expose lightweight statistics in debugfs Thomas Gleixner
2025-09-04 22:21 ` [patch V3 18/37] rseq: Provide static branch for runtime debugging Thomas Gleixner
2025-09-04 22:21 ` [patch V3 19/37] rseq: Provide and use rseq_update_user_cs() Thomas Gleixner
2025-09-04 22:21 ` [patch V3 20/37] rseq: Replace the original debug implementation Thomas Gleixner
2025-09-04 22:21 ` [patch V3 21/37] rseq: Make exit debugging static branch based Thomas Gleixner
2025-09-04 22:21 ` Thomas Gleixner [this message]
2025-09-04 22:21 ` [patch V3 23/37] rseq: Provide and use rseq_set_ids() Thomas Gleixner
2025-09-04 22:21 ` [patch V3 24/37] rseq: Separate the signal delivery path Thomas Gleixner
2025-09-04 22:21 ` [patch V3 25/37] rseq: Rework the TIF_NOTIFY handler Thomas Gleixner
2025-09-04 22:21 ` [patch V3 26/37] rseq: Optimize event setting Thomas Gleixner
2025-09-04 22:21 ` [patch V3 27/37] rseq: Implement fast path for exit to user Thomas Gleixner
2025-09-04 22:21 ` [patch V3 28/37] rseq: Switch to fast path processing on " Thomas Gleixner
2025-09-04 22:21 ` [patch V3 29/37] entry: Split up exit_to_user_mode_prepare() Thomas Gleixner
2025-09-04 22:21 ` [patch V3 30/37] rseq: Split up rseq_exit_to_user_mode() Thomas Gleixner
2025-09-04 22:21 ` [patch V3 31/37] asm-generic: Provide generic TIF infrastructure Thomas Gleixner
2025-09-04 22:21 ` [patch V3 32/37] x86: Use generic TIF bits Thomas Gleixner
2025-09-04 22:21 ` [patch V3 33/37] s390: " Thomas Gleixner
2025-09-04 22:21 ` [patch V3 34/37] loongarch: " Thomas Gleixner
2025-09-04 22:21 ` [patch V3 35/37] riscv: " Thomas Gleixner
2025-09-04 22:21 ` [patch V3 36/37] rseq: Switch to TIF_RSEQ if supported Thomas Gleixner
2025-09-04 22:21 ` [patch V3 37/37] entry/rseq: Optimize for TIF_RSEQ on exit Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250904185720.526220243@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=arnd@arndb.de \
    --cc=axboe@kernel.dk \
    --cc=boqun.feng@gmail.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=chenhuacai@kernel.org \
    --cc=decui@microsoft.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mjeanson@efficios.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=paulmck@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=seanjc@google.com \
    --cc=svens@linux.ibm.com \
    --cc=wei.liu@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox