From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
"Donald Hunter" <donald.hunter@gmail.com>,
"Simon Horman" <horms@kernel.org>,
"Jacob Keller" <jacob.e.keller@intel.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
wireguard@lists.zx2c4.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [RFC net-next 08/14] uapi: wireguard: generate header with ynl-gen
Date: Thu, 4 Sep 2025 22:02:42 +0000 [thread overview]
Message-ID: <20250904220255.1006675-8-ast@fiberby.net> (raw)
In-Reply-To: <20250904-wg-ynl-rfc@fiberby.net>
Use ynl-gen to generate the UAPI header for wireguard.
Changes in generated header:
* As __*_F_ALL are not generated by ynl-gen:
* All users have been replaced by their current value.
* Once the policies are also generated, then the
NLA_POLICY_MASK() policies will be kept in sync.
* Convert the last bit-shifted flag value in enum wgdevice_flag.
* Trivial include guard rename.
* Trivial white space changes.
No behavioural changes intended.
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
drivers/net/wireguard/netlink.c | 6 +++---
include/uapi/linux/wireguard.h | 26 +++++++++++---------------
2 files changed, 14 insertions(+), 18 deletions(-)
diff --git a/drivers/net/wireguard/netlink.c b/drivers/net/wireguard/netlink.c
index 742d3f88d132..5dae2aa51346 100644
--- a/drivers/net/wireguard/netlink.c
+++ b/drivers/net/wireguard/netlink.c
@@ -24,7 +24,7 @@ static const struct nla_policy device_policy[WGDEVICE_A_MAX + 1] = {
[WGDEVICE_A_IFNAME] = { .type = NLA_NUL_STRING, .len = IFNAMSIZ - 1 },
[WGDEVICE_A_PRIVATE_KEY] = NLA_POLICY_EXACT_LEN(WG_KEY_LEN),
[WGDEVICE_A_PUBLIC_KEY] = NLA_POLICY_EXACT_LEN(WG_KEY_LEN),
- [WGDEVICE_A_FLAGS] = NLA_POLICY_MASK(NLA_U32, __WGDEVICE_F_ALL),
+ [WGDEVICE_A_FLAGS] = NLA_POLICY_MASK(NLA_U32, 1),
[WGDEVICE_A_LISTEN_PORT] = { .type = NLA_U16 },
[WGDEVICE_A_FWMARK] = { .type = NLA_U32 },
[WGDEVICE_A_PEERS] = NLA_POLICY_NESTED_ARRAY(peer_policy),
@@ -33,7 +33,7 @@ static const struct nla_policy device_policy[WGDEVICE_A_MAX + 1] = {
static const struct nla_policy peer_policy[WGPEER_A_MAX + 1] = {
[WGPEER_A_PUBLIC_KEY] = NLA_POLICY_EXACT_LEN(WG_KEY_LEN),
[WGPEER_A_PRESHARED_KEY] = NLA_POLICY_EXACT_LEN(WG_KEY_LEN),
- [WGPEER_A_FLAGS] = NLA_POLICY_MASK(NLA_U32, __WGPEER_F_ALL),
+ [WGPEER_A_FLAGS] = NLA_POLICY_MASK(NLA_U32, 7),
[WGPEER_A_ENDPOINT] = NLA_POLICY_MIN_LEN(sizeof(struct sockaddr)),
[WGPEER_A_PERSISTENT_KEEPALIVE_INTERVAL] = { .type = NLA_U16 },
[WGPEER_A_LAST_HANDSHAKE_TIME] = NLA_POLICY_EXACT_LEN(sizeof(struct __kernel_timespec)),
@@ -47,7 +47,7 @@ static const struct nla_policy allowedip_policy[WGALLOWEDIP_A_MAX + 1] = {
[WGALLOWEDIP_A_FAMILY] = { .type = NLA_U16 },
[WGALLOWEDIP_A_IPADDR] = NLA_POLICY_MIN_LEN(sizeof(struct in_addr)),
[WGALLOWEDIP_A_CIDR_MASK] = { .type = NLA_U8 },
- [WGALLOWEDIP_A_FLAGS] = NLA_POLICY_MASK(NLA_U32, __WGALLOWEDIP_F_ALL),
+ [WGALLOWEDIP_A_FLAGS] = NLA_POLICY_MASK(NLA_U32, 1),
};
static struct wg_device *lookup_interface(struct nlattr **attrs,
diff --git a/include/uapi/linux/wireguard.h b/include/uapi/linux/wireguard.h
index 623ec9527e22..b83973aed9f8 100644
--- a/include/uapi/linux/wireguard.h
+++ b/include/uapi/linux/wireguard.h
@@ -1,32 +1,28 @@
-/* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR MIT */
-/*
- * Copyright (C) 2015-2019 Jason A. Donenfeld <Jason@zx2c4.com>. All Rights Reserved.
- */
+/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */
+/* Do not edit directly, auto-generated from: */
+/* Documentation/netlink/specs/wireguard.yaml */
+/* YNL-GEN uapi header */
-#ifndef _WG_UAPI_WIREGUARD_H
-#define _WG_UAPI_WIREGUARD_H
+#ifndef _UAPI_LINUX_WIREGUARD_H
+#define _UAPI_LINUX_WIREGUARD_H
-#define WG_GENL_NAME "wireguard"
-#define WG_GENL_VERSION 1
+#define WG_GENL_NAME "wireguard"
+#define WG_GENL_VERSION 1
-#define WG_KEY_LEN 32
+#define WG_KEY_LEN 32
enum wgdevice_flag {
- WGDEVICE_F_REPLACE_PEERS = 1U << 0,
- __WGDEVICE_F_ALL = WGDEVICE_F_REPLACE_PEERS
+ WGDEVICE_F_REPLACE_PEERS = 1,
};
enum wgpeer_flag {
WGPEER_F_REMOVE_ME = 1,
WGPEER_F_REPLACE_ALLOWEDIPS = 2,
WGPEER_F_UPDATE_ONLY = 4,
- __WGPEER_F_ALL = WGPEER_F_REMOVE_ME | WGPEER_F_REPLACE_ALLOWEDIPS |
- WGPEER_F_UPDATE_ONLY
};
enum wgallowedip_flag {
WGALLOWEDIP_F_REMOVE_ME = 1,
- __WGALLOWEDIP_F_ALL = WGALLOWEDIP_F_REMOVE_ME
};
enum wgdevice_attribute {
@@ -80,4 +76,4 @@ enum wg_cmd {
};
#define WG_CMD_MAX (__WG_CMD_MAX - 1)
-#endif /* _WG_UAPI_WIREGUARD_H */
+#endif /* _UAPI_LINUX_WIREGUARD_H */
--
2.51.0
next prev parent reply other threads:[~2025-09-04 22:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 22:02 [RFC net-next 00/14] wireguard: netlink: ynl conversion Asbjørn Sloth Tønnesen
2025-09-04 22:02 ` [RFC net-next 01/14] wireguard: netlink: use WG_KEY_LEN in policies Asbjørn Sloth Tønnesen
2025-09-04 22:02 ` [RFC net-next 02/14] wireguard: netlink: validate nested arrays in policy Asbjørn Sloth Tønnesen
2025-09-04 22:02 ` [RFC net-next 03/14] netlink: specs: add specification for wireguard Asbjørn Sloth Tønnesen
2025-09-04 22:02 ` [RFC net-next 04/14] netlink: specs: wireguard: add remaining checks Asbjørn Sloth Tønnesen
2025-09-04 22:02 ` [RFC net-next 05/14] uapi: wireguard: use __*_A_MAX in enums Asbjørn Sloth Tønnesen
2025-09-04 22:02 ` [RFC net-next 06/14] uapi: wireguard: move enum wg_cmd Asbjørn Sloth Tønnesen
2025-09-04 22:02 ` [RFC net-next 07/14] uapi: wireguard: move flag enums Asbjørn Sloth Tønnesen
2025-09-04 22:02 ` Asbjørn Sloth Tønnesen [this message]
2025-09-04 22:02 ` [RFC net-next 09/14] wireguard: netlink: convert to split ops Asbjørn Sloth Tønnesen
2025-09-04 22:02 ` [RFC net-next 10/14] wireguard: netlink: rename netlink handlers Asbjørn Sloth Tønnesen
2025-09-04 22:02 ` [RFC net-next 11/14] wireguard: netlink: generate netlink code Asbjørn Sloth Tønnesen
2025-09-04 22:02 ` [RFC net-next 12/14] netlink: specs: wireguard: alternative to wireguard_params.h Asbjørn Sloth Tønnesen
2025-09-04 22:02 ` [RFC net-next 13/14] wireguard: netlink: enable strict genetlink validation Asbjørn Sloth Tønnesen
2025-09-04 22:02 ` [RFC net-next 14/14] tools: ynl: add sample for wireguard Asbjørn Sloth Tønnesen
2025-09-16 15:51 ` [RFC net-next 00/14] wireguard: netlink: ynl conversion Jason A. Donenfeld
2025-09-17 11:52 ` Asbjørn Sloth Tønnesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904220255.1006675-8-ast@fiberby.net \
--to=ast@fiberby.net \
--cc=Jason@zx2c4.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox