public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] dt-bindings: rtc: pcf85063: remove quartz-load-femtofarads restriction for nxp,pcf85063
@ 2025-09-03 19:11 Frank Li
  2025-09-04 19:11 ` Rob Herring (Arm)
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Frank Li @ 2025-09-03 19:11 UTC (permalink / raw)
  To: Alexandre Belloni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Alexander Stein, open list:REAL TIME CLOCK (RTC) SUBSYSTEM,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: imx

Original TXT binding doc have not limitition about quartz-load-femtofarads,
which only allow 7000 for nxp,pcf85063.

So remove it to fix below CHECK_DTBS warnings:
arch/arm/boot/dts/nxp/imx/imx6dl-skov-revc-lt2.dtb: rtc@51 (nxp,pcf85063): quartz-load-femtofarads:0: 7000 was expected
        from schema $id: http://devicetree.org/schemas/rtc/nxp,pcf85063.yaml#

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../devicetree/bindings/rtc/nxp,pcf85063.yaml          | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
index 1e6277e524c27..f7013cd8fc20b 100644
--- a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
+++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
@@ -62,16 +62,6 @@ allOf:
     then:
       properties:
         quartz-load-femtofarads: false
-  - if:
-      properties:
-        compatible:
-          contains:
-            enum:
-              - nxp,pcf85063
-    then:
-      properties:
-        quartz-load-femtofarads:
-          const: 7000
   - if:
       properties:
         compatible:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] dt-bindings: rtc: pcf85063: remove quartz-load-femtofarads restriction for nxp,pcf85063
  2025-09-03 19:11 [PATCH 1/1] dt-bindings: rtc: pcf85063: remove quartz-load-femtofarads restriction for nxp,pcf85063 Frank Li
@ 2025-09-04 19:11 ` Rob Herring (Arm)
  2025-09-05  7:18 ` Alexandre Belloni
  2025-09-14 21:16 ` Alexandre Belloni
  2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring (Arm) @ 2025-09-04 19:11 UTC (permalink / raw)
  To: Frank Li
  Cc: Krzysztof Kozlowski, devicetree, Alexander Stein, Conor Dooley,
	Alexandre Belloni, linux-kernel, imx, linux-rtc


On Wed, 03 Sep 2025 15:11:27 -0400, Frank Li wrote:
> Original TXT binding doc have not limitition about quartz-load-femtofarads,
> which only allow 7000 for nxp,pcf85063.
> 
> So remove it to fix below CHECK_DTBS warnings:
> arch/arm/boot/dts/nxp/imx/imx6dl-skov-revc-lt2.dtb: rtc@51 (nxp,pcf85063): quartz-load-femtofarads:0: 7000 was expected
>         from schema $id: http://devicetree.org/schemas/rtc/nxp,pcf85063.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../devicetree/bindings/rtc/nxp,pcf85063.yaml          | 10 ----------
>  1 file changed, 10 deletions(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] dt-bindings: rtc: pcf85063: remove quartz-load-femtofarads restriction for nxp,pcf85063
  2025-09-03 19:11 [PATCH 1/1] dt-bindings: rtc: pcf85063: remove quartz-load-femtofarads restriction for nxp,pcf85063 Frank Li
  2025-09-04 19:11 ` Rob Herring (Arm)
@ 2025-09-05  7:18 ` Alexandre Belloni
  2025-09-05 14:23   ` Frank Li
  2025-09-14 21:16 ` Alexandre Belloni
  2 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2025-09-05  7:18 UTC (permalink / raw)
  To: Frank Li
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alexander Stein,
	open list:REAL TIME CLOCK (RTC) SUBSYSTEM,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list, imx

On 03/09/2025 15:11:27-0400, Frank Li wrote:
> Original TXT binding doc have not limitition about quartz-load-femtofarads,
> which only allow 7000 for nxp,pcf85063.

The only valid values are 7000 and 12500, wouldn't it be better to
improve the limitation rather than removing it?

> 
> So remove it to fix below CHECK_DTBS warnings:
> arch/arm/boot/dts/nxp/imx/imx6dl-skov-revc-lt2.dtb: rtc@51 (nxp,pcf85063): quartz-load-femtofarads:0: 7000 was expected
>         from schema $id: http://devicetree.org/schemas/rtc/nxp,pcf85063.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../devicetree/bindings/rtc/nxp,pcf85063.yaml          | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> index 1e6277e524c27..f7013cd8fc20b 100644
> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> @@ -62,16 +62,6 @@ allOf:
>      then:
>        properties:
>          quartz-load-femtofarads: false
> -  - if:
> -      properties:
> -        compatible:
> -          contains:
> -            enum:
> -              - nxp,pcf85063
> -    then:
> -      properties:
> -        quartz-load-femtofarads:
> -          const: 7000
>    - if:
>        properties:
>          compatible:
> -- 
> 2.34.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] dt-bindings: rtc: pcf85063: remove quartz-load-femtofarads restriction for nxp,pcf85063
  2025-09-05  7:18 ` Alexandre Belloni
@ 2025-09-05 14:23   ` Frank Li
  0 siblings, 0 replies; 5+ messages in thread
From: Frank Li @ 2025-09-05 14:23 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alexander Stein,
	open list:REAL TIME CLOCK (RTC) SUBSYSTEM,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list, imx

On Fri, Sep 05, 2025 at 09:18:32AM +0200, Alexandre Belloni wrote:
> On 03/09/2025 15:11:27-0400, Frank Li wrote:
> > Original TXT binding doc have not limitition about quartz-load-femtofarads,
> > which only allow 7000 for nxp,pcf85063.
>
> The only valid values are 7000 and 12500, wouldn't it be better to
> improve the limitation rather than removing it?

There are already have such restriction in top

  quartz-load-femtofarads:
    description:
      The capacitive load of the quartz(x-tal).
    enum: [7000, 12500]

This just remove restriction, which allow only 7000 for nxp,pcf85063

Frank
>
> >
> > So remove it to fix below CHECK_DTBS warnings:
> > arch/arm/boot/dts/nxp/imx/imx6dl-skov-revc-lt2.dtb: rtc@51 (nxp,pcf85063): quartz-load-femtofarads:0: 7000 was expected
> >         from schema $id: http://devicetree.org/schemas/rtc/nxp,pcf85063.yaml#
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  .../devicetree/bindings/rtc/nxp,pcf85063.yaml          | 10 ----------
> >  1 file changed, 10 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> > index 1e6277e524c27..f7013cd8fc20b 100644
> > --- a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> > @@ -62,16 +62,6 @@ allOf:
> >      then:
> >        properties:
> >          quartz-load-femtofarads: false
> > -  - if:
> > -      properties:
> > -        compatible:
> > -          contains:
> > -            enum:
> > -              - nxp,pcf85063
> > -    then:
> > -      properties:
> > -        quartz-load-femtofarads:
> > -          const: 7000
> >    - if:
> >        properties:
> >          compatible:
> > --
> > 2.34.1
> >
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] dt-bindings: rtc: pcf85063: remove quartz-load-femtofarads restriction for nxp,pcf85063
  2025-09-03 19:11 [PATCH 1/1] dt-bindings: rtc: pcf85063: remove quartz-load-femtofarads restriction for nxp,pcf85063 Frank Li
  2025-09-04 19:11 ` Rob Herring (Arm)
  2025-09-05  7:18 ` Alexandre Belloni
@ 2025-09-14 21:16 ` Alexandre Belloni
  2 siblings, 0 replies; 5+ messages in thread
From: Alexandre Belloni @ 2025-09-14 21:16 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alexander Stein,
	linux-rtc, devicetree, linux-kernel, Frank Li
  Cc: imx

On Wed, 03 Sep 2025 15:11:27 -0400, Frank Li wrote:
> Original TXT binding doc have not limitition about quartz-load-femtofarads,
> which only allow 7000 for nxp,pcf85063.
> 
> So remove it to fix below CHECK_DTBS warnings:
> arch/arm/boot/dts/nxp/imx/imx6dl-skov-revc-lt2.dtb: rtc@51 (nxp,pcf85063): quartz-load-femtofarads:0: 7000 was expected
>         from schema $id: http://devicetree.org/schemas/rtc/nxp,pcf85063.yaml#
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: rtc: pcf85063: remove quartz-load-femtofarads restriction for nxp,pcf85063
      https://git.kernel.org/abelloni/c/b4bcfbfb1f0f

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-09-14 21:17 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-03 19:11 [PATCH 1/1] dt-bindings: rtc: pcf85063: remove quartz-load-femtofarads restriction for nxp,pcf85063 Frank Li
2025-09-04 19:11 ` Rob Herring (Arm)
2025-09-05  7:18 ` Alexandre Belloni
2025-09-05 14:23   ` Frank Li
2025-09-14 21:16 ` Alexandre Belloni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox