From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0329F1F8677; Mon, 8 Sep 2025 07:31:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.194.8.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757316700; cv=none; b=IThMggUmQ+EI/Q4fpvkWGjQFhiQxj1T679SHV/61z3cI5v/zqhetVmOcHEGPgD9biJWoeiFeGwvsXG/Nq35lIpqjaJjG6xMmMV6t2g74smnI7BgXAXLdyFizzzTPlL1tj776lzNU6MXlYnAmza+PRhwWOucaC/FCoPzDa+HYvjI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757316700; c=relaxed/simple; bh=v3m9LwUd0Y9PzuKCXM7M3/P4b5ZcQEYY2Z85OfdshAA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Il9T6VPlor+dntOzpTV1VZn9M35B0Q/jPW2/5vSa1xSVIRGe5ZBrU2NujayZbOQTQbZoL450In16YpyZk55CjEaCXJHlQOrxZSV8jG4uaskkam7X3xV/boWGKvJ2qmsoshhlpcno3Fi05lcJ1kxy5hSoy4pQDM+pu6JpGZIxRK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it; spf=pass smtp.mailfrom=dolcini.it; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b=JNHa6r+Q; arc=none smtp.client-ip=217.194.8.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dolcini.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dolcini.it header.i=@dolcini.it header.b="JNHa6r+Q" Received: from francesco-nb (248.201.173.83.static.wline.lns.sme.cust.swisscom.ch [83.173.201.248]) by mail11.truemail.it (Postfix) with ESMTPA id ED16C22915; Mon, 8 Sep 2025 09:31:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1757316688; bh=U4EwWMsxDabkSM0GPrxSyxdtohsW4c5vwvEqfUMOq7U=; h=From:To:Subject; b=JNHa6r+QQjWSJlRdDj8i9Vk7C/b52jf+ZyKQiE7mHeT56BBT/jEMv6ekUpcwgl/4T AlRYqE4iiI4it37hn4VPWJBcAtkhq4VWhLLVLtNzlEhzpBY0JKecnUkDuQqWR2kcxh pi4jKvGwIdXwYthk2/UCZbuS0/N1eAAH5hI9OBvQBij6XlJvehNVr6n77Uo4uC+ZUY jOTll6BJY4bVuPIfduekld65nxjsX/pFS1t5fvnmbbQpYqWEOvyqJfFE30AsrTANpa 0GW6/D02wcsxgNoHKCdOWhNrU9kx1h1TUGU2Uuz6kyrbPGV+U02hdJ1vfcCR8SmxKN AJLdIBkWGu2Ug== Date: Mon, 8 Sep 2025 09:31:24 +0200 From: Francesco Dolcini To: Tomi Valkeinen , Andrzej Hajda , Neil Armstrong , Robert Foss Cc: Vitor Soares , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Vitor Soares , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Aradhya Bhatia , Jayesh Choudhary , stable@vger.kernel.org Subject: Re: [PATCH v3] drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS() Message-ID: <20250908073124.GA12200@francesco-nb> References: <20250512083215.436149-1-ivitro@gmail.com> <546ef388-299b-4d97-8633-9508fab4475a@ideasonboard.com> <20250822070401.GA15925@francesco-nb> <09441f4b-bdd1-46c9-876e-2ff503dd1160@ideasonboard.com> <20250822090038.GA28190@francesco-nb> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250822090038.GA28190@francesco-nb> Hello all, On Fri, Aug 22, 2025 at 11:00:38AM +0200, Francesco Dolcini wrote: > On Fri, Aug 22, 2025 at 11:46:40AM +0300, Tomi Valkeinen wrote: > > On 22/08/2025 10:04, Francesco Dolcini wrote: > > > On Thu, May 22, 2025 at 12:09:08PM +0300, Tomi Valkeinen wrote: > > >> On 12/05/2025 11:32, Vitor Soares wrote: > > >>> From: Vitor Soares > > >>> > > >>> The deprecated UNIVERSAL_DEV_PM_OPS() macro uses the provided callbacks > > >>> for both runtime PM and system sleep. This causes the DSI clocks to be > > >>> disabled twice: once during runtime suspend and again during system > > >>> suspend, resulting in a WARN message from the clock framework when > > >>> attempting to disable already-disabled clocks. > > >>> > > >>> [ 84.384540] clk:231:5 already disabled > > >>> [ 84.388314] WARNING: CPU: 2 PID: 531 at /drivers/clk/clk.c:1181 clk_core_disable+0xa4/0xac > > >>> ... > > >>> [ 84.579183] Call trace: > > >>> [ 84.581624] clk_core_disable+0xa4/0xac > > >>> [ 84.585457] clk_disable+0x30/0x4c > > >>> [ 84.588857] cdns_dsi_suspend+0x20/0x58 [cdns_dsi] > > >>> [ 84.593651] pm_generic_suspend+0x2c/0x44 > > >>> [ 84.597661] ti_sci_pd_suspend+0xbc/0x15c > > >>> [ 84.601670] dpm_run_callback+0x8c/0x14c > > >>> [ 84.605588] __device_suspend+0x1a0/0x56c > > >>> [ 84.609594] dpm_suspend+0x17c/0x21c > > >>> [ 84.613165] dpm_suspend_start+0xa0/0xa8 > > >>> [ 84.617083] suspend_devices_and_enter+0x12c/0x634 > > >>> [ 84.621872] pm_suspend+0x1fc/0x368 > > >>> > > >>> To address this issue, replace UNIVERSAL_DEV_PM_OPS() with > > >>> SET_RUNTIME_PM_OPS(), enabling suspend/resume handling through the > > >>> _enable()/_disable() hooks managed by the DRM framework for both > > >>> runtime and system-wide PM. > > >>> > > >>> Cc: # 6.1.x > > >>> Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") > > >>> Signed-off-by: Vitor Soares > > > > > > ping on this, Tomi, maybe you can pick this one or is there any > > > concern ? > > > > No concern from my side, but I'm not a bridge or cdns-dsi maintainer, so > > I don't pick any of these to drm-misc by default. > > > > Aaand now as I wrote that, I realized I just some time ago pushed the > > cdns-dsi series ("drm/bridge: cdns-dsi: Make it work a bit better") to > > Yep, that's the reason I assumed you could also pick this one. Any > DRM bridge maintainer can help here? Another ping here ... I am not sure on how to move this forward. Andrzej? Neil? Robert? Considering that this is a bug fix, the patch is reviewed since long and it was sent 4 months ago would be fine that you merge it Tomi? Francesco