Re: [PATCH v2 23/23] staging: media: tegra-video: add CSI support for Tegra20 and Tegra30

kernel test robot
2025-09-15T05:47:44Z

Hi Svyatoslav,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tegra/for-next]
[also build test WARNING on robh/for-next clk/clk-next linus/master v6.17-rc6]
[cannot apply to next-20250912]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Svyatoslav-Ryhel/clk-tegra-set-CSUS-as-vi_sensors-gate-for-Tegra20-Tegra30-and-Tegra114/20250906-215750
base: https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
patch link: https://lore.kernel.org/r/20250906135345.241229-24-clamor95%40gmail.com
patch subject: [PATCH v2 23/23] staging: media: tegra-video: add CSI support for Tegra20 and Tegra30
config: arm-randconfig-r131-20250915 (https://download.01.org/0day-ci/archive/20250915/202509151319.M4lQXwA8-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 21857ae337e0892a5522b6e7337899caa61de2a6)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250915/202509151319.M4lQXwA8-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509151319.M4lQXwA8-lkp@intel.com/

All warnings (new ones prefixed by >>):

In file included from <built-in>:3:
In file included from include/linux/compiler_types.h:171:
include/linux/compiler-clang.h:28:9: warning: '__SANITIZE_ADDRESS__' macro redefined [-Wmacro-redefined]
28 | #define __SANITIZE_ADDRESS__
| ^
<built-in>:366:9: note: previous definition is here
366 | #define __SANITIZE_ADDRESS__ 1
| ^
>> drivers/staging/media/tegra-video/tegra20.c:909:6: warning: variable 'pp' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
909 | if (ret < 0) {
| ^~~~~~~
drivers/staging/media/tegra-video/tegra20.c:923:53: note: uninitialized use occurs here
923 | tegra20_mipi_write(mipi, TEGRA_CSI_CSI_CIL_STATUS, pp);
| ^~
drivers/staging/media/tegra-video/tegra20.c:909:2: note: remove the 'if' if its condition is always false
909 | if (ret < 0) {
| ^~~~~~~~~~~~~~
910 | dev_warn(csi->dev, "MIPI calibration status timeout!\n");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
911 | goto exit;
| ~~~~~~~~~~
912 | }
| ~
drivers/staging/media/tegra-video/tegra20.c:900:6: warning: variable 'pp' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
900 | if (ret < 0) {
| ^~~~~~~
drivers/staging/media/tegra-video/tegra20.c:923:53: note: uninitialized use occurs here
923 | tegra20_mipi_write(mipi, TEGRA_CSI_CSI_CIL_STATUS, pp);
| ^~
drivers/staging/media/tegra-video/tegra20.c:900:2: note: remove the 'if' if its condition is always false
900 | if (ret < 0) {
| ^~~~~~~~~~~~~~
901 | dev_warn(csi->dev, "MIPI calibration timeout!\n");
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
902 | goto exit;
| ~~~~~~~~~~
903 | }
| ~
drivers/staging/media/tegra-video/tegra20.c:886:15: note: initialize the variable 'pp' to silence this warning
886 | u32 value, pp, cil;
| ^
| = 0
3 warnings generated.

vim +909 drivers/staging/media/tegra-video/tegra20.c

880
881 static int tegra20_finish_pad_calibration(struct tegra_mipi_device *mipi)
882 {
883 struct tegra_csi *csi = mipi->csi;
884 void __iomem *cil_status_reg = csi->iomem + TEGRA_CSI_CSI_CIL_STATUS;
885 unsigned int port = mipi->pads;
886 u32 value, pp, cil;
887 int ret;
888
889 /* This part is only for CSI */
890 if (port > PORT_B) {
891 pm_runtime_put(csi->dev);
892
893 return 0;
894 }
895
896 guard(mutex)(&csi->mipi_lock);
897
898 ret = readl_relaxed_poll_timeout(cil_status_reg, value,
899 value & CSI_MIPI_AUTO_CAL_DONE, 50, 250000);
900 if (ret < 0) {
901 dev_warn(csi->dev, "MIPI calibration timeout!\n");
902 goto exit;
903 }
904
905 /* clear status */
906 tegra20_mipi_write(mipi, TEGRA_CSI_CSI_CIL_STATUS, value);
907 ret = readl_relaxed_poll_timeout(cil_status_reg, value,
908 !(value & CSI_MIPI_AUTO_CAL_DONE), 50, 250000);
> 909 if (ret < 0) {
910 dev_warn(csi->dev, "MIPI calibration status timeout!\n");
911 goto exit;
912 }
913
914 pp = tegra20_mipi_read(mipi, TEGRA_CSI_CSI_PIXEL_PARSER_STATUS);
915 cil = tegra20_mipi_read(mipi, TEGRA_CSI_CSI_CIL_STATUS);
916 if (pp | cil) {
917 dev_warn(csi->dev, "Calibration status not been cleared!\n");
918 ret = -EINVAL;
919 goto exit;
920 }
921
922 exit:
923 tegra20_mipi_write(mipi, TEGRA_CSI_CSI_CIL_STATUS, pp);
924
925 /* un-select to avoid interference with DSI */
926 tegra20_mipi_write(mipi, TEGRA_CSI_CILB_MIPI_CAL_CONFIG,
927 CSI_CIL_MIPI_CAL_HSPDOS(0) |
928 CSI_CIL_MIPI_CAL_HSPUOS(0) |
929 CSI_CIL_MIPI_CAL_TERMOS(4));
930
931 tegra20_mipi_write(mipi, TEGRA_CSI_CILA_MIPI_CAL_CONFIG,
932 CSI_CIL_MIPI_CAL_NOISE_FLT(0xa) |
933 CSI_CIL_MIPI_CAL_PRESCALE(0x2) |
934 CSI_CIL_MIPI_CAL_HSPDOS(0) |
935 CSI_CIL_MIPI_CAL_HSPUOS(0) |
936 CSI_CIL_MIPI_CAL_TERMOS(4));
937
938 pm_runtime_put(csi->dev);
939
940 return ret;
941 }
942

--
0-DAY CI Kernel Test Service