Re: [PATCH v11 06/23] CXL/AER: Introduce rch_aer.c into AER driver for handling CXL RCH errors

Bowman, Terry
2025-09-12T13:59:44Z

On 8/29/2025 3:39 AM, Lukas Wunner wrote:
> On Thu, Aug 28, 2025 at 01:53:35PM -0700, Dave Jiang wrote:
>> On 8/26/25 6:35 PM, Terry Bowman wrote:
>>> drivers/cxl/Kconfig | 9 +++-
>>> drivers/cxl/core/ras.c | 3 ++
>>> drivers/pci/pci.h | 20 +++++++
>>> drivers/pci/pcie/Makefile | 1 +
>>> drivers/pci/pcie/aer.c | 108 +++----------------------------------
>>> drivers/pci/pcie/rch_aer.c | 99 ++++++++++++++++++++++++++++++++++
>> I wonder if this should be cxl_rch_aer.c to be clear that it's cxl
>> related code.
> I'd prefer an "aer_" prefix at the beginning of filenames,
> but maybe that's just me...
>
> Thanks,
>
> Lukas

Hi Lukas,

After discussing off-thread I understand you prefer changing the name here to be
drivers/pci/pcie/aer_cxl_rch.c.

Also, the non-RCH changes should be added to a file named drivers/pci/pcie/aer_cxl_vh.c
in the later patch (CXL/AER: Introduce cxl_aer.c into AER driver for forwarding CXL errors).

Can you confirm the name changes are as you prefer?

Terry