From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DE8D27877B for ; Wed, 10 Sep 2025 11:47:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757504871; cv=none; b=JIL/PP3qtSyTNR6oSrJ6ziMRGKHtnO2kp8irZ4ViDbxCXSeae/ig0I6dfut39AJWYHUcaxUCll+/V8LV9OzsZS8tX2BxQdJgzR3fwnpd7LvuNQSlDfuyzZCXm4elPIHgFqx1IyOQonPjaYhaMPyXvLRd0oYn2enBCjRTGXKYDUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757504871; c=relaxed/simple; bh=WbEtV0CPIKyH7FQXM3VCsQudJJTxDRA8dDx1E0cAO8k=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=A4wO86h/wkBiLDkKpALLNaWqAj8GHL9LzMY0B44PJUMwE6ENrCK4EyFglMAKvrH+7KQwndixF58eT5T5S+J5eiTEq1Oj5UaoDuPQ/OSe2KSkJoVgLL8R1ngPw3pV5/nabR7RuBDiuq9b8O8XqcOD1t6YHUU7t5NS46CnQi2VuLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=O9gURqIr; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="O9gURqIr" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3e4aeaa57b9so3738812f8f.1 for ; Wed, 10 Sep 2025 04:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757504867; x=1758109667; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wg2Ph+PhoATIteAbw+PWkWD/06VwBl1ynTVTQY5RYgk=; b=O9gURqIr9IXa2PiraV3ZG7m/kA7qet5iK0WosCDX5sreMI53xvu9CX5pcAKsHD6lss IhfW0/1izzHtY72t1Bakxg5sr0satsgbo2Zx1JJALWxvbRuUcj3niVR954LQZxrioBAI K5AD3d8tH0DNixG6vQ1LT8hUmCtMONWUtbbEQF9j4bitVo3mo/hEJIQlubqB4Jbm0umu onyV8Buze+gqHxcl4qABdDLoa5zsxboHn8O74UUk7G7FpELaIYDoNlcG2tUzfe7145fB 6seaVpf0EUW6i5c523mYuFUwUQb46rKiCARkFu/uSZyn5zXU09/93xiq4MD43ART4Luk hTTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757504868; x=1758109668; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wg2Ph+PhoATIteAbw+PWkWD/06VwBl1ynTVTQY5RYgk=; b=Z5tX1JJXJx+5iOH9fUexgN70/98+MbOdpnXUVcbFFoxQawYZJJZtG6m6+OZ4oAr9rg y5Dw1/djxgzIyDacCeuI3/wT1Q1tsYno3nb4hdK3K/aBhW6oAKOaIy6b86tvLcFNwlAi g1o7rqfWvSlKIl7mfUw+k8vpW/IB23opFMa9Rbt3mcePfeMfAqQyX5/nMFfyGPHfAyay aH+unxNQLLwqPnMYxvPinJsJU3cpR8vnWV38dBAHAN4Wu+M5rgFwMnKvnGb2vEzr5JZw Ea/6EbO7oa+baTdrkEV+nIF+aZlLQ0A4BEtFeOCCGux9utYLGi1dyA3OO+hMXm0N/B7A CIFg== X-Forwarded-Encrypted: i=1; AJvYcCWtACBT5CCSrbqU5S2rFZi9ZzQnsrLXEvEunghiuGTJytS3aAhGBR4V3Jey8/iu+KcTnl5Xw97b/nWEKT4=@vger.kernel.org X-Gm-Message-State: AOJu0YyHnccS6nb23jkQVgIl1CVI+VQj7sxr94ai7BVDnkuyK7xZqYqX VHdYefS0tefnPFodL8KGnm3iGCIMFoOqb1FbFiQluAYbuVLdLe4U1b8azT8pL0Ih+3I= X-Gm-Gg: ASbGncvHXeWE7J40iFd0fK+AGdku7V588Qyn3uxJKi24a+WIaf97lDTiXc2GeNwzpMx 8s3gItOFvsiFovNLuS5KQnW2CBPop8oHw/MMEA0P1QxbczWOSCTY1IFqr5bxqJ7o7g6AaZu2ruJ RrrEqOPilIxMdt7zY6QFmGmgDLSm8ybCIkzmwNX+2rmLAEskxZNRa42S0/EQVSGi/w653GQVqX7 pGYb8NvlWIym3v1sB6UkwVd8A98IajHCifSGubQzXIU1Vj/WRT1zj1I66Jc0NUC0huNw5SByNlM 7UbVq8kujSrzw88le3OAl2iqUbsmCWYVMiCJDpaAO4PNhDA0LQdjdDTM5yGCCwntUNu+vWiofL4 sBr76pKF2gLW/clJWWB+MJmCqM4U= X-Google-Smtp-Source: AGHT+IHpMaxaSaJ4cnLK/bK8wa1YrfXhxVJLuuDTkuh1vmaIEZ84Pcyd9YYbH8IfZoLQCxj9xtJuUA== X-Received: by 2002:adf:b350:0:b0:3e7:41ac:45f8 with SMTP id ffacd0b85a97d-3e741ac4939mr7821201f8f.55.1757504867368; Wed, 10 Sep 2025 04:47:47 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3e7521bfe00sm6893713f8f.5.2025.09.10.04.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 04:47:46 -0700 (PDT) Date: Wed, 10 Sep 2025 14:47:43 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, GuangFei Luo , "Rafael J . Wysocki" Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, luogf2025@163.com Subject: Re: [PATCH] ACPI: battery: prevent sysfs_add_battery re-entry on rapid events Message-ID: <202509101620.yI0HZ5gT-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250907035154.223983-1-luogf2025@163.com> Hi GuangFei, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/GuangFei-Luo/ACPI-battery-prevent-sysfs_add_battery-re-entry-on-rapid-events/20250907-115505 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next patch link: https://lore.kernel.org/r/20250907035154.223983-1-luogf2025%40163.com patch subject: [PATCH] ACPI: battery: prevent sysfs_add_battery re-entry on rapid events config: x86_64-randconfig-161-20250909 (https://download.01.org/0day-ci/archive/20250910/202509101620.yI0HZ5gT-lkp@intel.com/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202509101620.yI0HZ5gT-lkp@intel.com/ smatch warnings: drivers/acpi/battery.c:1046 acpi_battery_update() warn: inconsistent returns '&battery->sysfs_lock'. vim +1046 drivers/acpi/battery.c 9e50bc14a7f58b5 Lan Tianyu 2014-05-04 1001 static int acpi_battery_update(struct acpi_battery *battery, bool resume) 508df92d1f8d192 Andrey Borzenkov 2007-10-28 1002 { 82f2d30570b7ecd Lucas Rangit Magasweran 2018-07-14 1003 int result = acpi_battery_get_status(battery); 82f2d30570b7ecd Lucas Rangit Magasweran 2018-07-14 1004 508df92d1f8d192 Andrey Borzenkov 2007-10-28 1005 if (result) 508df92d1f8d192 Andrey Borzenkov 2007-10-28 1006 return result; 82f2d30570b7ecd Lucas Rangit Magasweran 2018-07-14 1007 508df92d1f8d192 Andrey Borzenkov 2007-10-28 1008 if (!acpi_battery_present(battery)) { 508df92d1f8d192 Andrey Borzenkov 2007-10-28 1009 sysfs_remove_battery(battery); 97749cd9adbb298 Alexey Starikovskiy 2008-01-01 1010 battery->update_time = 0; 508df92d1f8d192 Andrey Borzenkov 2007-10-28 1011 return 0; 508df92d1f8d192 Andrey Borzenkov 2007-10-28 1012 } 9e50bc14a7f58b5 Lan Tianyu 2014-05-04 1013 9e50bc14a7f58b5 Lan Tianyu 2014-05-04 1014 if (resume) 9e50bc14a7f58b5 Lan Tianyu 2014-05-04 1015 return 0; 9e50bc14a7f58b5 Lan Tianyu 2014-05-04 1016 82f2d30570b7ecd Lucas Rangit Magasweran 2018-07-14 1017 if (!battery->update_time) { 97749cd9adbb298 Alexey Starikovskiy 2008-01-01 1018 result = acpi_battery_get_info(battery); 97749cd9adbb298 Alexey Starikovskiy 2008-01-01 1019 if (result) 97749cd9adbb298 Alexey Starikovskiy 2008-01-01 1020 return result; 97749cd9adbb298 Alexey Starikovskiy 2008-01-01 1021 acpi_battery_init_alarm(battery); 97749cd9adbb298 Alexey Starikovskiy 2008-01-01 1022 } 12c78ca2ab5e64b Carlos Garnacho 2016-08-10 1023 12c78ca2ab5e64b Carlos Garnacho 2016-08-10 1024 result = acpi_battery_get_state(battery); 12c78ca2ab5e64b Carlos Garnacho 2016-08-10 1025 if (result) 12c78ca2ab5e64b Carlos Garnacho 2016-08-10 1026 return result; 12c78ca2ab5e64b Carlos Garnacho 2016-08-10 1027 acpi_battery_quirks(battery); 12c78ca2ab5e64b Carlos Garnacho 2016-08-10 1028 ce5e61beaad5c5a GuangFei Luo 2025-09-07 1029 mutex_lock(&battery->sysfs_lock); 297d716f6260cc9 Krzysztof Kozlowski 2015-03-12 1030 if (!battery->bat) { eb03cb02b74df6d Stefan Hajnoczi 2011-07-12 1031 result = sysfs_add_battery(battery); eb03cb02b74df6d Stefan Hajnoczi 2011-07-12 1032 if (result) eb03cb02b74df6d Stefan Hajnoczi 2011-07-12 1033 return result; mutex_unlock(&battery->sysfs_lock) before returning. eb03cb02b74df6d Stefan Hajnoczi 2011-07-12 1034 } ce5e61beaad5c5a GuangFei Luo 2025-09-07 1035 mutex_unlock(&battery->sysfs_lock); e0d1f09e311fafa Zhang Rui 2014-05-28 1036 e0d1f09e311fafa Zhang Rui 2014-05-28 1037 /* e0d1f09e311fafa Zhang Rui 2014-05-28 1038 * Wakeup the system if battery is critical low e0d1f09e311fafa Zhang Rui 2014-05-28 1039 * or lower than the alarm level e0d1f09e311fafa Zhang Rui 2014-05-28 1040 */ e0d1f09e311fafa Zhang Rui 2014-05-28 1041 if ((battery->state & ACPI_BATTERY_STATE_CRITICAL) || e0d1f09e311fafa Zhang Rui 2014-05-28 1042 (test_bit(ACPI_BATTERY_ALARM_PRESENT, &battery->flags) && e0d1f09e311fafa Zhang Rui 2014-05-28 1043 (battery->capacity_now <= battery->alarm))) 33e4f80ee69b516 Rafael J. Wysocki 2017-06-12 1044 acpi_pm_wakeup_event(&battery->device->dev); e0d1f09e311fafa Zhang Rui 2014-05-28 1045 557d58687dcdee6 Zhang Rui 2010-10-22 @1046 return result; 4bd35cdb1e2d1a1 Vladimir Lebedev 2007-02-10 1047 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki