Re: [PATCH v7 0/3] dt-bindings: mfd: twl: Consolidate and fix TI TWL family bindings

Krzysztof Kozlowski
2025-09-11T07:07:08Z

On 11/09/2025 08:43, Andreas Kemnade wrote:
> Am Thu, 11 Sep 2025 08:35:32 +0200
> schrieb Krzysztof Kozlowski <krzk@kernel.org>:
>
>> On Wed, Sep 10, 2025 at 06:07:01PM +0200, Jihed Chaibi wrote:
>>> This version addresses a final piece of feedback from Andreas to make
>>> the twl4030/twl6030-specific child nodes (audio, usb, keypad etc.)
>>> conditional by moving them out of the common block, which now only
>>> contains common properties (rtc, charger, pwm, pwmled..) ensuring
>>> the schema is fully accurate.
>>>
>>> The complete dtbs_check for this binding is clean except for two
>>> warnings originating from pre-existing bugs in the OMAP DTS files,
>>> for which fixes have already been submitted separately [1][2].
>>>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>> Acked-by: Uwe Kleine-König <ukleinek@kernel.org>
>>>
>>> ---
>>> Changes in v7:
>>> - (1/3): Moved twl4030/twl6030-specific child node definitions (audio,
>>> usb etc.) into the conditional 'if/then' block to improve schema
>>> accuracy.
>>
>> Who asked for this? It's wrong code.
>>
> maybe I was not clear there. That was not was I meant. As far as I
> understand, the correct pattern is to define things outside of the
> if/then block and
> then disable it with property-name: false in the if/then block
> Example: Handling of regulator-initial-mode property.

Yes, I read your comment afterwards and that is how I would understand
it as well.

But the patch here is done differently.

Best regards,
Krzysztof