From: Peter Zijlstra <peterz@infradead.org>
To: Fernand Sieber <sieberf@amazon.com>
Cc: mingo@redhat.com, vincent.guittot@linaro.org,
juri.lelli@redhat.com, dietmar.eggemann@arm.com,
bsegall@google.com, graf@amazon.com, wangtao554@huawei.com,
tanghui20@huawei.com, zhangqiao22@huawei.com,
linux-kernel@vger.kernel.org, nh-open-source@amazon.com,
Madadi Vineeth Reddy <vineethr@linux.ibm.com>
Subject: Re: [PATCH RESEND] sched/fair: Only increment deadline once on yield
Date: Thu, 11 Sep 2025 13:37:46 +0200 [thread overview]
Message-ID: <20250911113746.GO4067720@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20250911095113.203439-1-sieberf@amazon.com>
On Thu, Sep 11, 2025 at 11:51:13AM +0200, Fernand Sieber wrote:
> If a task yields, the scheduler may decide to pick it again. The task in
> turn may decide to yield immediately or shortly after, leading to a tight
> loop of yields.
>
> If there's another runnable task as this point, the deadline will be
> increased by the slice at each loop. This can cause the deadline to runaway
> pretty quickly, and subsequent elevated run delays later on as the task
> doesn't get picked again. The reason the scheduler can pick the same task
> again and again despite its deadline increasing is because it may be the
> only eligible task at that point.
>
> Fix this by updating the deadline only to one slice ahead.
>
> Note, we might want to consider iterating on the implementation of yield as
> follow up:
> * the yielding task could be forfeiting its remaining slice by
> incrementing its vruntime correspondingly
This..
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index b173a059315c..d6a0d22d08d7 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -8921,7 +8921,7 @@ static void yield_task_fair(struct rq *rq)
> */
> rq_clock_skip_update(rq);
>
> - se->deadline += calc_delta_fair(se->slice, se);
> + se->deadline = se->vruntime + calc_delta_fair(se->slice, se);
Have you tried:
se->vruntime = se->deadline;
se->deadline += calc_delta_fair(se->slice, se);
instead?
next prev parent reply other threads:[~2025-09-11 11:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 9:51 [PATCH RESEND] sched/fair: Only increment deadline once on yield Fernand Sieber
2025-09-11 11:03 ` Alexander Graf
2025-09-11 11:37 ` Peter Zijlstra [this message]
2025-09-11 13:56 ` Peter Zijlstra
2025-09-16 13:35 ` Fernand Sieber
2025-09-16 14:02 ` [PATCH v2] sched/fair: Forfeit vruntime " Fernand Sieber
2025-09-16 16:00 ` Fernand Sieber
2025-09-18 6:43 ` Peter Zijlstra
2025-09-18 10:21 ` Peter Zijlstra
2025-09-18 15:05 ` [PATCH v3] " Fernand Sieber
2025-09-24 8:25 ` kernel test robot
2025-09-26 4:56 ` kernel test robot
2025-10-16 9:33 ` [tip: sched/core] " tip-bot2 for Fernand Sieber
2025-11-05 9:13 ` [PATCH v4] " Fernand Sieber
2025-09-17 19:22 ` [PATCH v2] " Fernand Sieber
2025-09-18 2:45 ` Xuewen Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250911113746.GO4067720@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=graf@amazon.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nh-open-source@amazon.com \
--cc=sieberf@amazon.com \
--cc=tanghui20@huawei.com \
--cc=vincent.guittot@linaro.org \
--cc=vineethr@linux.ibm.com \
--cc=wangtao554@huawei.com \
--cc=zhangqiao22@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox