Re: [PATCH net-next v05 09/14] hinic3: Queue pair context initialization

Simon Horman
2025-09-11T12:30:15Z

On Tue, Sep 09, 2025 at 03:33:34PM +0800, Fan Gong wrote:
> Initialize queue pair context of hardware interaction.
>
> Co-developed-by: Zhu Yikai <zhuyikai1@h-partners.com>
> Signed-off-by: Zhu Yikai <zhuyikai1@h-partners.com>
> Signed-off-by: Fan Gong <gongfan1@huawei.com>

The nit below notwithstanding, this looks good to me.

...

> diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c b/drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c

...

> +static int clean_qp_offload_ctxt(struct hinic3_nic_dev *nic_dev)
> +{
> + /* clean LRO/TSO context space */
> + return (clean_queue_offload_ctxt(nic_dev, HINIC3_QP_CTXT_TYPE_SQ) ||
> + clean_queue_offload_ctxt(nic_dev, HINIC3_QP_CTXT_TYPE_RQ));

nit: unnecessary outer parentheses

> +}

...