[PATCH] mfd: tps6594: Explicitly include bitfield.h

[PATCH] mfd: tps6594: Explicitly include bitfield.h

[Nathan Chancellor]

After a recent change that started using FIELD_GET() in tps6594-core.c,
there is an error when bitfield.h is not implicitly included, such as
when building allmodconfig for ARCH=hexagon:

  drivers/mfd/tps6594-core.c:767:7: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    767 |                 if (FIELD_GET(TPS65224_MASK_EN_PB_VSENSE_CONFIG, pwr_on) == TPS65224_EN_SEL_PB ||
        |                     ^

Explicitly include bitfield.h to resolve the errors.

Fixes: d766ca01c208 ("mfd: tps6594: Add power button functionality")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
It looks like this should go into ib-mfd-input-6.18.
---
 drivers/mfd/tps6594-core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/tps6594-core.c b/drivers/mfd/tps6594-core.c
index 7127af7142f5..8b26c4127472 100644
--- a/drivers/mfd/tps6594-core.c
+++ b/drivers/mfd/tps6594-core.c
@@ -10,6 +10,7 @@
  * Copyright (C) 2023 BayLibre Incorporated - https://www.baylibre.com/
  */
 
+#include <linux/bitfield.h>
 #include <linux/completion.h>
 #include <linux/delay.h>
 #include <linux/interrupt.h>

---
base-commit: a4eb677652a5da4d8e7271c0c0c8719c39f10e36
change-id: 20250904-mfd-tps6594-core-fix-bitfield-h-74a2e3d632fc

Best regards,
--  
Nathan Chancellor <nathan@kernel.org>

Re: [PATCH] mfd: tps6594: Explicitly include bitfield.h

[Michael Walle]

[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]

Hi Nathan,

On Fri Sep 5, 2025 at 3:26 AM CEST, Nathan Chancellor wrote:
> After a recent change that started using FIELD_GET() in tps6594-core.c,
> there is an error when bitfield.h is not implicitly included, such as
> when building allmodconfig for ARCH=hexagon:

Thanks! I was already in a discussion with Lee about how to handle
that.

>   drivers/mfd/tps6594-core.c:767:7: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>     767 |                 if (FIELD_GET(TPS65224_MASK_EN_PB_VSENSE_CONFIG, pwr_on) == TPS65224_EN_SEL_PB ||
>         |                     ^
>
> Explicitly include bitfield.h to resolve the errors.
>
> Fixes: d766ca01c208 ("mfd: tps6594: Add power button functionality")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

In any case:
Reviewed-by: Michael Walle <mwalle@kernel.org>

Also,
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202509032356.LGa5hygM-lkp@intel.com/

> ---
> It looks like this should go into ib-mfd-input-6.18.

Yeah probably. Lee, is that possible?

-michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

Re: (subset) [PATCH] mfd: tps6594: Explicitly include bitfield.h

[Lee Jones]

On Thu, 04 Sep 2025 18:26:12 -0700, Nathan Chancellor wrote:
> After a recent change that started using FIELD_GET() in tps6594-core.c,
> there is an error when bitfield.h is not implicitly included, such as
> when building allmodconfig for ARCH=hexagon:
> 
>   drivers/mfd/tps6594-core.c:767:7: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
>     767 |                 if (FIELD_GET(TPS65224_MASK_EN_PB_VSENSE_CONFIG, pwr_on) == TPS65224_EN_SEL_PB ||
>         |                     ^
> 
> [...]

Applied, thanks!

[1/1] mfd: tps6594: Explicitly include bitfield.h
      commit: a377b1be3a0ed51ccabfe22908ebde065848313c

--
Lee Jones [李琼斯]

Re: [PATCH] mfd: tps6594: Explicitly include bitfield.h

[Lee Jones]

On Fri, 05 Sep 2025, Michael Walle wrote:

> Hi Nathan,
> 
> On Fri Sep 5, 2025 at 3:26 AM CEST, Nathan Chancellor wrote:
> > After a recent change that started using FIELD_GET() in tps6594-core.c,
> > there is an error when bitfield.h is not implicitly included, such as
> > when building allmodconfig for ARCH=hexagon:
> 
> Thanks! I was already in a discussion with Lee about how to handle
> that.
> 
> >   drivers/mfd/tps6594-core.c:767:7: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> >     767 |                 if (FIELD_GET(TPS65224_MASK_EN_PB_VSENSE_CONFIG, pwr_on) == TPS65224_EN_SEL_PB ||
> >         |                     ^
> >
> > Explicitly include bitfield.h to resolve the errors.
> >
> > Fixes: d766ca01c208 ("mfd: tps6594: Add power button functionality")
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> 
> In any case:
> Reviewed-by: Michael Walle <mwalle@kernel.org>
> 
> Also,
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202509032356.LGa5hygM-lkp@intel.com/
> 
> > ---
> > It looks like this should go into ib-mfd-input-6.18.
> 
> Yeah probably. Lee, is that possible?

Hold my beer!

-- 
Lee Jones [李琼斯]

Re: [PATCH] mfd: tps6594: Explicitly include bitfield.h

[Lee Jones]

On Thu, 11 Sep 2025, Lee Jones wrote:

> On Fri, 05 Sep 2025, Michael Walle wrote:
> 
> > Hi Nathan,
> > 
> > On Fri Sep 5, 2025 at 3:26 AM CEST, Nathan Chancellor wrote:
> > > After a recent change that started using FIELD_GET() in tps6594-core.c,
> > > there is an error when bitfield.h is not implicitly included, such as
> > > when building allmodconfig for ARCH=hexagon:
> > 
> > Thanks! I was already in a discussion with Lee about how to handle
> > that.
> > 
> > >   drivers/mfd/tps6594-core.c:767:7: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> > >     767 |                 if (FIELD_GET(TPS65224_MASK_EN_PB_VSENSE_CONFIG, pwr_on) == TPS65224_EN_SEL_PB ||
> > >         |                     ^
> > >
> > > Explicitly include bitfield.h to resolve the errors.
> > >
> > > Fixes: d766ca01c208 ("mfd: tps6594: Add power button functionality")
> > > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > 
> > In any case:
> > Reviewed-by: Michael Walle <mwalle@kernel.org>
> > 
> > Also,
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202509032356.LGa5hygM-lkp@intel.com/
> > 
> > > ---
> > > It looks like this should go into ib-mfd-input-6.18.
> > 
> > Yeah probably. Lee, is that possible?
> 
> Hold my beer!

https://lore.kernel.org/all/20250911151400.GR9224@google.com/

-- 
Lee Jones [李琼斯]