public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Phil Auld <pauld@redhat.com>
To: frederic@kernel.org
Cc: bsegall@google.com, dietmar.eggemann@arm.com,
	juri.lelli@redhat.com, linux-kernel@vger.kernel.org,
	mgorman@suse.de, mingo@redhat.com, pauld@redhat.com,
	peterz@infradead.org, rostedt@goodmis.org, tanghui20@huawei.com,
	tglx@linutronix.de, vincent.guittot@linaro.org,
	wangtao554@huawei.com, zhangqiao22@huawei.com,
	Waiman Long <longman@redhat.com>
Subject: [PATCH] sched: Increase sched_tick_remote timeout
Date: Thu, 11 Sep 2025 12:13:00 -0400	[thread overview]
Message-ID: <20250911161300.437944-1-pauld@redhat.com> (raw)
In-Reply-To: <aMLs5G3WvlXOAxuY@localhost.localdomain>

Increase the sched_tick_remote WARN_ON timeout to remove false
positives due to temporarily busy HK cpus. The suggestion
was 30 seconds to catch really stuck remote tick processing
but not trigger it too easily.

Signed-off-by: Phil Auld <pauld@redhat.com>
Suggested-by: Frederic Weisbecker <frederic@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <frederic@kernel.org>
---
 kernel/sched/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index be00629f0ba4..ef90d358252d 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5724,7 +5724,7 @@ static void sched_tick_remote(struct work_struct *work)
 				 * reasonable amount of time.
 				 */
 				u64 delta = rq_clock_task(rq) - curr->se.exec_start;
-				WARN_ON_ONCE(delta > (u64)NSEC_PER_SEC * 3);
+				WARN_ON_ONCE(delta > (u64)NSEC_PER_SEC * 30);
 			}
 			curr->sched_class->task_tick(rq, curr, 0);
 
-- 
2.51.0


  reply	other threads:[~2025-09-11 16:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11 12:42 [PATCH] sched/core: Fix potential deadlock on rq lock Wang Tao
2025-09-11 13:53 ` Peter Zijlstra
2025-09-11 15:02   ` Frederic Weisbecker
2025-09-11 15:14     ` Phil Auld
2025-09-11 15:38       ` Frederic Weisbecker
2025-09-11 16:13         ` Phil Auld [this message]
2025-09-11 16:29           ` [PATCH] sched: Increase sched_tick_remote timeout Frederic Weisbecker
2025-09-17  6:26             ` wangtao (EQ)
2025-09-16  8:44           ` wangtao (EQ)
2025-09-16 12:49             ` Phil Auld
2025-09-23 10:47           ` Phil Auld
2025-10-10 12:13             ` Phil Auld
2025-11-03 21:56             ` Phil Auld
2025-11-14 12:19           ` [tip: sched/core] " tip-bot2 for Phil Auld
2025-11-14 13:07             ` Phil Auld
2025-11-17 16:23           ` tip-bot2 for Phil Auld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250911161300.437944-1-pauld@redhat.com \
    --to=pauld@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=frederic@kernel.org \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tanghui20@huawei.com \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    --cc=wangtao554@huawei.com \
    --cc=zhangqiao22@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox