From: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
"Donald Hunter" <donald.hunter@gmail.com>,
"Simon Horman" <horms@kernel.org>,
"Jacob Keller" <jacob.e.keller@intel.com>,
"Sabrina Dubroca" <sd@queasysnail.net>,
wireguard@lists.zx2c4.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next v3 11/13] tools: ynl: encode indexed-arrays
Date: Thu, 11 Sep 2025 20:05:04 +0000 [thread overview]
Message-ID: <20250911200508.79341-12-ast@fiberby.net> (raw)
In-Reply-To: <20250911200508.79341-1-ast@fiberby.net>
This patch adds support for encoding indexed-array
attributes with sub-type nest in pyynl.
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
tools/net/ynl/pyynl/lib/ynl.py | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/tools/net/ynl/pyynl/lib/ynl.py b/tools/net/ynl/pyynl/lib/ynl.py
index 92ff26f34f4d..9fd83f8b091f 100644
--- a/tools/net/ynl/pyynl/lib/ynl.py
+++ b/tools/net/ynl/pyynl/lib/ynl.py
@@ -563,6 +563,11 @@ class YnlFamily(SpecFamily):
nl_type |= Netlink.NLA_F_NESTED
sub_space = attr['nested-attributes']
attr_payload = self._add_nest_attrs(value, sub_space, search_attrs)
+ elif attr['type'] == 'indexed-array' and attr['sub-type'] == 'nest':
+ nl_type |= Netlink.NLA_F_NESTED
+ sub_space = attr['nested-attributes']
+ attr_payload = self._encode_indexed_array(value, sub_space,
+ search_attrs)
elif attr["type"] == 'flag':
if not value:
# If value is absent or false then skip attribute creation.
@@ -616,6 +621,9 @@ class YnlFamily(SpecFamily):
else:
raise Exception(f'Unknown type at {space} {name} {value} {attr["type"]}')
+ return self._add_attr_raw(nl_type, attr_payload)
+
+ def _add_attr_raw(self, nl_type, attr_payload):
pad = b'\x00' * ((4 - len(attr_payload) % 4) % 4)
return struct.pack('HH', len(attr_payload) + 4, nl_type) + attr_payload + pad
@@ -627,6 +635,14 @@ class YnlFamily(SpecFamily):
sub_attrs)
return attr_payload
+ def _encode_indexed_array(self, vals, sub_space, search_attrs):
+ attr_payload = b''
+ for i, val in enumerate(vals):
+ idx = i | Netlink.NLA_F_NESTED
+ val_payload = self._add_nest_attrs(val, sub_space, search_attrs)
+ attr_payload += self._add_attr_raw(idx, val_payload)
+ return attr_payload
+
def _get_enum_or_unknown(self, enum, raw):
try:
name = enum.entries_by_val[raw].name
--
2.51.0
next prev parent reply other threads:[~2025-09-11 20:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 20:04 [PATCH net-next v3 00/13] tools: ynl: prepare for wireguard Asbjørn Sloth Tønnesen
2025-09-11 20:04 ` [PATCH net-next v3 01/13] tools: ynl-gen: allow overriding name-prefix for constants Asbjørn Sloth Tønnesen
2025-09-11 20:04 ` [PATCH net-next v3 02/13] tools: ynl-gen: generate nested array policies Asbjørn Sloth Tønnesen
2025-09-11 20:04 ` [PATCH net-next v3 03/13] tools: ynl-gen: add sub-type check Asbjørn Sloth Tønnesen
2025-09-11 20:04 ` [PATCH net-next v3 04/13] tools: ynl-gen: refactor local vars for .attr_put() callers Asbjørn Sloth Tønnesen
2025-09-12 11:23 ` Donald Hunter
2025-09-13 0:19 ` Jakub Kicinski
2025-09-13 23:14 ` Asbjørn Sloth Tønnesen
2025-09-11 20:04 ` [PATCH net-next v3 05/13] tools: ynl-gen: add CodeWriter.p_lines() helper Asbjørn Sloth Tønnesen
2025-09-13 0:21 ` Jakub Kicinski
2025-09-13 23:14 ` Asbjørn Sloth Tønnesen
2025-09-11 20:04 ` [PATCH net-next v3 06/13] tools: ynl-gen: deduplicate fixed_header handling Asbjørn Sloth Tønnesen
2025-09-12 11:24 ` Donald Hunter
2025-09-13 0:24 ` Jakub Kicinski
2025-09-13 23:14 ` Asbjørn Sloth Tønnesen
2025-09-11 20:05 ` [PATCH net-next v3 07/13] tools: ynl-gen: avoid repetitive variables definitions Asbjørn Sloth Tønnesen
2025-09-12 11:30 ` Donald Hunter
2025-09-11 20:05 ` [PATCH net-next v3 08/13] tools: ynl-gen: only validate nested array payload Asbjørn Sloth Tønnesen
2025-09-13 0:27 ` Jakub Kicinski
2025-09-13 23:14 ` Asbjørn Sloth Tønnesen
2025-09-11 20:05 ` [PATCH net-next v3 09/13] tools: ynl-gen: rename TypeArrayNest to TypeIndexedArray Asbjørn Sloth Tønnesen
2025-09-12 12:00 ` Donald Hunter
2025-09-11 20:05 ` [PATCH net-next v3 10/13] tools: ynl: move nest packing to a helper function Asbjørn Sloth Tønnesen
2025-09-11 20:05 ` Asbjørn Sloth Tønnesen [this message]
2025-09-12 12:01 ` [PATCH net-next v3 11/13] tools: ynl: encode indexed-arrays Donald Hunter
2025-09-11 20:05 ` [PATCH net-next v3 12/13] tools: ynl: decode hex input Asbjørn Sloth Tønnesen
2025-09-12 12:01 ` Donald Hunter
2025-09-11 20:05 ` [PATCH net-next v3 13/13] tools: ynl: add ipv4-or-v6 display hint Asbjørn Sloth Tønnesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250911200508.79341-12-ast@fiberby.net \
--to=ast@fiberby.net \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox