From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Benson Leung <bleung@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
Dawid Niedzwiecki <dawidn@google.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
chrome-platform@lists.linux.dev, linux-kselftest@vger.kernel.org,
tzungbi@kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: [PATCH v3 0/5] platform/chrome: Fix a possible UAF via revocable
Date: Fri, 12 Sep 2025 08:17:12 +0000 [thread overview]
Message-ID: <20250912081718.3827390-1-tzungbi@kernel.org> (raw)
This is a follow-up series of [1]. It tries to fix a possible UAF in the
fops of cros_ec_chardev after the underlying protocol device has gone by
using revocable.
The 1st patch introduces the revocable which is an implementation of ideas
from the talk [2].
The 2nd and 3rd patches add test cases for revocable in Kunit and selftest.
The 4th patch converts existing protocol devices to resource providers
of cros_ec_device.
The 5th patch converts cros_ec_chardev to a resource consumer of
cros_ec_device to fix the UAF.
[1] https://lore.kernel.org/chrome-platform/20250721044456.2736300-6-tzungbi@kernel.org/
[2] https://lpc.events/event/17/contributions/1627/
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
v3:
- Rebase onto https://lore.kernel.org/chrome-platform/20250828083601.856083-1-tzungbi@kernel.org
and next-20250912.
- Change the 4th patch accordingly.
v2: https://lore.kernel.org/chrome-platform/20250820081645.847919-1-tzungbi@kernel.org
- Rename "ref_proxy" -> "revocable".
- Add test cases in Kunit and selftest.
v1: https://lore.kernel.org/chrome-platform/20250814091020.1302888-1-tzungbi@kernel.org/
Tzung-Bi Shih (5):
revocable: Revocable resource management
revocable: Add Kunit test cases
selftests: revocable: Add kselftest cases
platform/chrome: Protect cros_ec_device lifecycle with revocable
platform/chrome: cros_ec_chardev: Consume cros_ec_device via revocable
.../driver-api/driver-model/index.rst | 1 +
.../driver-api/driver-model/revocable.rst | 151 ++++++++++++
MAINTAINERS | 9 +
drivers/base/Kconfig | 8 +
drivers/base/Makefile | 5 +-
drivers/base/revocable.c | 229 ++++++++++++++++++
drivers/base/revocable_test.c | 110 +++++++++
drivers/platform/chrome/cros_ec.c | 5 +
drivers/platform/chrome/cros_ec_chardev.c | 124 +++++++---
include/linux/platform_data/cros_ec_proto.h | 4 +
include/linux/revocable.h | 37 +++
tools/testing/selftests/Makefile | 1 +
.../selftests/drivers/base/revocable/Makefile | 7 +
.../drivers/base/revocable/revocable_test.c | 116 +++++++++
.../drivers/base/revocable/test-revocable.sh | 39 +++
.../base/revocable/test_modules/Makefile | 10 +
.../revocable/test_modules/revocable_test.c | 188 ++++++++++++++
17 files changed, 1003 insertions(+), 41 deletions(-)
create mode 100644 Documentation/driver-api/driver-model/revocable.rst
create mode 100644 drivers/base/revocable.c
create mode 100644 drivers/base/revocable_test.c
create mode 100644 include/linux/revocable.h
create mode 100644 tools/testing/selftests/drivers/base/revocable/Makefile
create mode 100644 tools/testing/selftests/drivers/base/revocable/revocable_test.c
create mode 100755 tools/testing/selftests/drivers/base/revocable/test-revocable.sh
create mode 100644 tools/testing/selftests/drivers/base/revocable/test_modules/Makefile
create mode 100644 tools/testing/selftests/drivers/base/revocable/test_modules/revocable_test.c
--
2.51.0.384.g4c02a37b29-goog
next reply other threads:[~2025-09-12 8:18 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 8:17 Tzung-Bi Shih [this message]
2025-09-12 8:17 ` [PATCH v3 1/5] revocable: Revocable resource management Tzung-Bi Shih
2025-09-12 9:05 ` Danilo Krummrich
2025-09-13 15:56 ` Tzung-Bi Shih
2025-09-12 13:27 ` Jonathan Corbet
2025-09-13 15:56 ` Tzung-Bi Shih
2025-09-17 5:24 ` Tzung-Bi Shih
2025-09-22 18:35 ` Simona Vetter
2025-09-12 8:17 ` [PATCH v3 2/5] revocable: Add Kunit test cases Tzung-Bi Shih
2025-09-12 8:17 ` [PATCH v3 3/5] selftests: revocable: Add kselftest cases Tzung-Bi Shih
2025-09-12 8:17 ` [PATCH v3 4/5] platform/chrome: Protect cros_ec_device lifecycle with revocable Tzung-Bi Shih
2025-09-12 8:17 ` [PATCH v3 5/5] platform/chrome: cros_ec_chardev: Consume cros_ec_device via revocable Tzung-Bi Shih
2025-09-12 8:30 ` [PATCH v3 0/5] platform/chrome: Fix a possible UAF " Greg Kroah-Hartman
2025-09-12 8:34 ` Danilo Krummrich
2025-09-12 9:20 ` Laurent Pinchart
2025-09-12 9:09 ` Krzysztof Kozlowski
2025-09-12 9:24 ` Bartosz Golaszewski
2025-09-12 12:49 ` Tzung-Bi Shih
2025-09-12 13:26 ` Laurent Pinchart
2025-09-12 13:39 ` Greg Kroah-Hartman
2025-09-12 13:45 ` Laurent Pinchart
2025-09-12 13:46 ` Bartosz Golaszewski
2025-09-12 13:59 ` Laurent Pinchart
2025-09-12 14:19 ` Greg Kroah-Hartman
2025-09-12 14:26 ` Laurent Pinchart
2025-09-12 14:40 ` Greg Kroah-Hartman
2025-09-12 14:44 ` Bartosz Golaszewski
2025-09-12 14:54 ` Laurent Pinchart
2025-09-12 16:22 ` Danilo Krummrich
2025-09-13 16:17 ` Laurent Pinchart
2025-09-22 22:43 ` dan.j.williams
2025-09-13 15:55 ` Tzung-Bi Shih
2025-09-13 16:14 ` Laurent Pinchart
2025-09-23 8:20 ` Tzung-Bi Shih
2025-09-12 14:53 ` Laurent Pinchart
2025-09-22 15:10 ` Jason Gunthorpe
2025-09-22 15:55 ` Danilo Krummrich
2025-09-22 17:40 ` Jason Gunthorpe
2025-09-22 18:42 ` Greg Kroah-Hartman
2025-09-22 20:17 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250912081718.3827390-1-tzungbi@kernel.org \
--to=tzungbi@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=dawidn@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=shuah@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox