Re: [PATCH v4 4/5] dt-bindings: usb: microchip,usb2514: add vbus-supply example

Marco Felsch
2025-09-12T15:31:00Z

On 25-09-12, Rob Herring wrote:
> On Fri, Sep 12, 2025 at 10:51:56AM +0200, Marco Felsch wrote:
> > On 25-09-11, Rob Herring (Arm) wrote:
> > >
> > > On Thu, 11 Sep 2025 22:22:45 +0200, Marco Felsch wrote:
> > > > Add an usb hub vbus-supply example to make it easier for users to
> > > > understand the binding, after the usb-device.yaml gained the support for
> > > > it.
> > > >
> > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > > ---
> > > > Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 7 +++++++
> > > > 1 file changed, 7 insertions(+)
> > > >
> > >
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > >
> > > yamllint warnings/errors:
> > >
> > > dtschema/dtc warnings/errors:
> > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/microchip,usb2514.example.dtb: ethernet@2 (usbb95,772b): 'vbus-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'
> > > from schema $id: http://devicetree.org/schemas/net/asix,ax88178.yaml#
> >
> > Well this is just an example on how to use it, we can drop this patch of
> > course.
>
> Yes, but how's it going to work for an actual user?

What do you mean? It's working as you requested:

hub@1 {
compatible = "..";
reg = <1>;

device@1 {
compatible = "..";
reg = <1>;

vbus-supply = <&vbus_supply_port1>;
};

device@4 {
compatible = "..";
reg = <4>;

vbus-supply = <&vbus_supply_port4>;
};
};

>
> Rob
>