From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2148305973 for ; Fri, 12 Sep 2025 18:32:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757701930; cv=none; b=jl7wuUWWP+dBSQNV+SLvgT2va/0d3VG6dF1BEgXqOiMho1MjSfpnceL7vduvoLBLlalX9x5dyj2NdbPfwpDLj2Jsnj7kOLjEfM103yi0GWec7pRDQlhw3C16tb163Q+JNHfN/5irARxHfWLO3N6CuymLKl33utUUL4ZrVr1vX8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757701930; c=relaxed/simple; bh=i6r5BnwccM40MN1CW61UawFe6hxRBJLKBNylPutF2lE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F0ZKErilhe4m9DJaA5N6MomsPFMGOXbjp1gfAiTjgxibqLrRqK2qgylIRARuEYmBxW/BcgIIL75i8j77FjyDjqHuG2L/xTKQjr45YZRRMtUeFFdKa1tU0ZzsNCzERi3mHWEu0wvSm/byyJDuI/ZVpMCHK8EbZxobdL0EfW2xCVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=gtScEg6q; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="gtScEg6q" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-4b5ed9d7e96so22649451cf.0 for ; Fri, 12 Sep 2025 11:32:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1757701927; x=1758306727; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=i6r5BnwccM40MN1CW61UawFe6hxRBJLKBNylPutF2lE=; b=gtScEg6qDFbFbyaJsTn1ZhxrKg+uf+sfG5Y9jGOwtd3dtq/EI5saMld8LmL6cRyJWb G6VRRZ/S4dv78/Eg7/N+SRhjFMHE+7/Ev2XR514YRCyFFRMqnMOH82pro2zabPYFe1Vx ZeeThqomwjgUMai+rpKPBzyxxeLF/uTEQJMYY+glp57SmZyPriPfdJvIv0395h5mnxkG tGQpBdQJk2q/i8Xe8gazNnmaKJeSwCEeUMceHpHHL0PUz7AO9bm2O1gSJG4z+d8ALgBT VkiR4Pjs5wk7DMncnKnkLHWWxzzJQR10go5MJk2wB8z6PZnpjk/I7uGY57eZByxxuRU4 wxmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757701927; x=1758306727; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i6r5BnwccM40MN1CW61UawFe6hxRBJLKBNylPutF2lE=; b=t2XWgLp1+R+6VjkQC4sVT+4Wv/sgaIUx0qmlVglWaD3NjZOeW0Ygn2f01NkuDsB4Si TkCzvk8imfVI/MkUnVcnIoRdP2AGdjqZ+cTjgRwIMg5cnEsnriPdiU4n2OoFZTy7MDov qdpBDtjPdvH4mh9W4sMZS5U3DqxXTxay+Mp1FTEOmZQBOtfspdHuMZGZrvuLwKmy1C92 0sY+D0uHt8lujZvACsSLt0RqlJla9vt7oYec0IG40XIXPpYbvgpJV6FVfrQjXNzttc1a 77Y40298n7d8/cAQEYfHIulV2aINp4egZlxohC740nLmVz64QFiw0xA1ii141XIANBPM 3/Iw== X-Forwarded-Encrypted: i=1; AJvYcCUQOmyuBOJFpl1jnGxUXTUjyNdlQ/EqiXBrCOW5JvttC0kLIbJcVly+Es2fbPYB2tTZrHPOrMEKg+w/2Qo=@vger.kernel.org X-Gm-Message-State: AOJu0YzHVkkJGvrdiPfS9ikK+XBhMswNAfcYQyBZlwNsCQupnBQQnPjT K3PvlT1aImtr/ylQ8CFDVNMtN604ToT3acbaGECT/K+6ZRl9piie7AxBJc29ImRzdls= X-Gm-Gg: ASbGncsxgMha+I8AfOsz06EjThchug720wQenZYzPtxs0G/7vn4jpGEjs+u0M2ZEE0r f1wHTs2FBA2H+Hr2z0wOFDyAZnGjjKXknhNXAx2GGnP8C6Tra9+Q6KlpItOqqjtiD/8kzEiOt8f Cm0gj5fDHXsKIDIUtAsGuRphTG7dNKp3nPRmJOhkDRutAKznnQmV5TJwHwbMEHDCJBe1+0wdv7j TJIpds03OVIYg/o/wQzeyoDKs6xQGbQkbJrMcYFky/piKXkPOhliFF3aiwh+wfpvr2Qh3yfo1He d8WAMY7ZzeBTKRflqJtmkelon1BWnfNRr/qmMnfXM0kKbns0gsRAzO6NEgwNe/L3+Ea+JvngbPv CoDKA8BbAAcNYMOjxoqn2bOApG2lu+cxQQRp+VN5DuaA4KGbetNyaSMUpOfTYoeNu4mw7tAoFcT gbrBw= X-Google-Smtp-Source: AGHT+IHZhwwJ1GAAakUbDyWBchcEmOdwvmn5VpYqCpYR267goBUbd6qsiAamIt0D50PzjBgabwMTEA== X-Received: by 2002:a05:622a:2c7:b0:4b5:d6db:eea1 with SMTP id d75a77b69052e-4b6348bd37dmr127954271cf.39.1757701927559; Fri, 12 Sep 2025 11:32:07 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id af79cd13be357-820c8ac45a3sm313988985a.5.2025.09.12.11.32.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Sep 2025 11:32:06 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1ux8Z4-000000047N0-0oCq; Fri, 12 Sep 2025 15:32:06 -0300 Date: Fri, 12 Sep 2025 15:32:06 -0300 From: Jason Gunthorpe To: Nicolas Dufresne Cc: =?utf-8?B?SsO2cmcgUsO2ZGVs?= , Benjamin Gaignard , robin.murphy@arm.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, p.zabel@pengutronix.de, mchehab@kernel.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com, linux-media@vger.kernel.org Subject: Re: [PATCH v9 3/7] iommu: Add verisilicon IOMMU driver Message-ID: <20250912183206.GH882933@ziepe.ca> References: <20250911155720.180465-1-benjamin.gaignard@collabora.com> <20250911155720.180465-4-benjamin.gaignard@collabora.com> <694b9ba15cd67f41a38f4a65a3811f035cf8e99d.camel@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <694b9ba15cd67f41a38f4a65a3811f035cf8e99d.camel@collabora.com> On Fri, Sep 12, 2025 at 01:37:11PM -0400, Nicolas Dufresne wrote: > To me this rejection isn't about Benjamin's driver, all iommu seems to look > alike, so anyone else that would have sent new driver would have face the same > issue. Yes, many drivers looks approximately alike.. To the extent possible we should be making more helpers and tools to lift common patterns out of the drivers. I don't know how much of that applies to rockchip vs verisilicon though. Obviously I'm tackling the page table stuff. Much of the other common code is tracking attachments and invalidation requirements. I'm hopeful the general method Nicolin is working on can be lifted and shared. Certainly it is better than what is in any of the three server focused drivers. But I don't know how much this brings to these simpler drivers. It seems strange to be talking about merging drivers that don't share a common IP supplier or register programming model. Jason