From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firewire: core: remove useless lockdep_assert_held()
Date: Sat, 13 Sep 2025 19:51:23 +0900 [thread overview]
Message-ID: <20250913105123.GA777602@workstation.local> (raw)
In-Reply-To: <20250911221312.678076-1-o-takashi@sakamocchi.jp>
On Fri, Sep 12, 2025 at 07:13:11AM +0900, Takashi Sakamoto wrote:
> The bm_work work item should be scheduled after holding fw_card reference
> counting. At a commit 25feb1a96e21 ("firewire: core: use cleanup function
> in bm_work"), I misinterpreted it as fw_card spinlock and inserted
> lockdep_assert_hold() wrongly.
>
> This commit removes the useless line.
>
> Fixes: 25feb1a96e21 ("firewire: core: use cleanup function in bm_work")
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
> drivers/firewire/core-card.c | 2 --
> 1 file changed, 2 deletions(-)
Applied to for-next branch.
Regards
Takashi Sakamoto
prev parent reply other threads:[~2025-09-13 10:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 22:13 [PATCH] firewire: core: remove useless lockdep_assert_held() Takashi Sakamoto
2025-09-13 10:51 ` Takashi Sakamoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250913105123.GA777602@workstation.local \
--to=o-takashi@sakamocchi.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox