* [PATCH] firewire: core: remove useless lockdep_assert_held()
@ 2025-09-11 22:13 Takashi Sakamoto
2025-09-13 10:51 ` Takashi Sakamoto
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Sakamoto @ 2025-09-11 22:13 UTC (permalink / raw)
To: linux1394-devel; +Cc: linux-kernel
The bm_work work item should be scheduled after holding fw_card reference
counting. At a commit 25feb1a96e21 ("firewire: core: use cleanup function
in bm_work"), I misinterpreted it as fw_card spinlock and inserted
lockdep_assert_hold() wrongly.
This commit removes the useless line.
Fixes: 25feb1a96e21 ("firewire: core: use cleanup function in bm_work")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
drivers/firewire/core-card.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/firewire/core-card.c b/drivers/firewire/core-card.c
index 474d8066e090..32cf6b3344cd 100644
--- a/drivers/firewire/core-card.c
+++ b/drivers/firewire/core-card.c
@@ -294,8 +294,6 @@ static void bm_work(struct work_struct *work)
int expected_gap_count, generation, grace;
bool do_reset = false;
- lockdep_assert_held(&card->lock);
-
spin_lock_irq(&card->lock);
if (card->local_node == NULL) {
--
2.48.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] firewire: core: remove useless lockdep_assert_held()
2025-09-11 22:13 [PATCH] firewire: core: remove useless lockdep_assert_held() Takashi Sakamoto
@ 2025-09-13 10:51 ` Takashi Sakamoto
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Sakamoto @ 2025-09-13 10:51 UTC (permalink / raw)
To: linux1394-devel; +Cc: linux-kernel
On Fri, Sep 12, 2025 at 07:13:11AM +0900, Takashi Sakamoto wrote:
> The bm_work work item should be scheduled after holding fw_card reference
> counting. At a commit 25feb1a96e21 ("firewire: core: use cleanup function
> in bm_work"), I misinterpreted it as fw_card spinlock and inserted
> lockdep_assert_hold() wrongly.
>
> This commit removes the useless line.
>
> Fixes: 25feb1a96e21 ("firewire: core: use cleanup function in bm_work")
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
> drivers/firewire/core-card.c | 2 --
> 1 file changed, 2 deletions(-)
Applied to for-next branch.
Regards
Takashi Sakamoto
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-13 10:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-11 22:13 [PATCH] firewire: core: remove useless lockdep_assert_held() Takashi Sakamoto
2025-09-13 10:51 ` Takashi Sakamoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox