Re: [PATCH v5 02/12] gpu: nova-core: move GSP boot code to a dedicated method

Danilo Krummrich
2025-09-13T13:30:44Z

On Sat Sep 13, 2025 at 3:02 AM CEST, Joel Fernandes wrote:
> Any chance we can initialize the locks later? We don't need locking until
> after the boot process is completed, and if there's a way we can dynamically
> "pin", where we hypothetically pin after the boot process completed, that
> might also work. Though I am not sure if that's something possible in
> Rust/rust4linux or if it makes sense.

We can't partially initialize structures and then rely on accessing initialized
data only. This is one of the sources for memory bugs that Rust tries to solve.

You can wrap fields into Option types and initialize them later, which would
defer pin-init calls for the price of having Option fields around.

However, we should never do such things. If there's the necessity to do
something like that, it indicates a design issue.

In this case, there's no problem, we can use pin-init without any issues right
away, and should do so.

pin-init is going to be an essential part of *every* Rust driver given that a
lot of the C infrastruture that we abstract requires pinned initialization, such
as locks and other synchronization primitives.