Re: [PATCH v2 0/2] drm/panthor: initial mt8196 support

Steven Price
2025-10-06T09:54:55Z

On 13/09/2025 01:21, Chia-I Wu wrote:
> MediaTek MT8196 has Mali-G925-Immortalis, for which panthor gained
> support recently. But the soc also requires custom ASN hash to be
> enabled. This series introduces panthor_soc_data for per-soc data and
> uses it to enable custom ASN hash on MT8196.
>
> The clk/regulator provider on MT8196 is GPUEB, whose driver[1] needs to
> be cleaned up and upstreamed separately.
>
> This initial support also lacks support for some hw configs. On some
> configs, panthor is expected to query a mask from efuse to mask out
> unavailable shader cores from ptdev->gpu_info.shader_present. This
> requires extending panthor_soc_data with a callback to read the mask.
>
> This is an RFC because the dependent drivers are not ready yet. But I
> would like to gather opinions on having panthor_soc_data for
> soc-specific data and having CONFIG_DRM_PANTHOR_SOC_MT8196 for
> soc-specific code.
>
> [1] https://gitlab.freedesktop.org/olv/kernel/-/commit/170d5fc90f817dc90bde54b32872c59cf5c77779

Applied to drm-misc-next.

Thanks,
Steve

>
> ---
> v2:
>
> - drop RFC as this series works with the downstream GPUEB driver, and
> should work with Nicolas's GPUEB driver posted to
> https://lore.kernel.org/lkml/20250912-mt8196-gpufreq-v2-0-779a8a3729d9@collabora.com/
> with no change.
> - remove CONFIG_DRM_PANTHOR_SOC_MT8196 and panthor_soc*.[ch], as this
> initial support is just about ASN hash.
>
> Chia-I Wu (2):
> dt-bindings: gpu: mali-valhall-csf: add MediaTek MT8196 compatible
> drm/panthor: add custom ASN_HASH support for mt8196
>
> .../bindings/gpu/arm,mali-valhall-csf.yaml | 1 +
> drivers/gpu/drm/panthor/panthor_device.c | 2 ++
> drivers/gpu/drm/panthor/panthor_device.h | 14 +++++++++++
> drivers/gpu/drm/panthor/panthor_drv.c | 6 +++++
> drivers/gpu/drm/panthor/panthor_gpu.c | 25 ++++++++++++++++++-
> drivers/gpu/drm/panthor/panthor_regs.h | 4 +++
> 6 files changed, 51 insertions(+), 1 deletion(-)
>