Re: [PATCH v2 11/25] genirq: Kill handle_percpu_devid_fasteoi_nmi()

Marc Zyngier
2025-09-21T15:32:17Z

On Tue, 16 Sep 2025 16:38:38 +0100,
Jonathan Cameron <jonathan.cameron@huawei.com> wrote:
>
> On Mon, 15 Sep 2025 09:56:48 +0100
> Marc Zyngier <maz@kernel.org> wrote:
>
> > There is no in-tree user of this flow handler anymore, so simply
> > remove it.
> >
> > Suggested-by: Will Deacon <will@kernel.org>
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
> > ---
>
> > diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> > index 0d0276378c707..869068ec6ac91 100644
> > --- a/kernel/irq/chip.c
> > +++ b/kernel/irq/chip.c
> > @@ -892,7 +892,8 @@ void handle_percpu_irq(struct irq_desc *desc)
> > *
> > * action->percpu_dev_id is a pointer to percpu variables which
> > * contain the real device id for the cpu on which this handler is
> > - * called
> > + * called. This is also used for per-CPU NMIs, so special care is
> > + * required.
>
> Probably belongs in previous patch as not really related to removing
> the unused code, but meh.

Actually, I think I'll simply drop this comment. It really doesn't
bring much to the table.

Thanks,

M.

--
Jazz isn't dead. It just smells funny.