* [PATCH] xtensa: use HZ_PER_MHZ in platform_calibrate_ccount
@ 2025-09-15 12:05 Thorsten Blum
2025-09-15 15:39 ` Max Filippov
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2025-09-15 12:05 UTC (permalink / raw)
To: Chris Zankel, Max Filippov; +Cc: Thorsten Blum, linux-kernel
Replace the hardcoded 1000000UL with the HZ_PER_MHZ unit macro, and add
a space in "10 MHz" to improve the readability of the error message.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/xtensa/kernel/platform.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/xtensa/kernel/platform.c b/arch/xtensa/kernel/platform.c
index 926b8bf0f14c..f14713060fd4 100644
--- a/arch/xtensa/kernel/platform.c
+++ b/arch/xtensa/kernel/platform.c
@@ -14,6 +14,7 @@
#include <linux/printk.h>
#include <linux/types.h>
+#include <linux/units.h>
#include <asm/platform.h>
#include <asm/timex.h>
@@ -38,7 +39,7 @@ void __weak platform_idle(void)
#ifdef CONFIG_XTENSA_CALIBRATE_CCOUNT
void __weak platform_calibrate_ccount(void)
{
- pr_err("ERROR: Cannot calibrate cpu frequency! Assuming 10MHz.\n");
- ccount_freq = 10 * 1000000UL;
+ pr_err("ERROR: Cannot calibrate cpu frequency! Assuming 10 MHz.\n");
+ ccount_freq = 10 * HZ_PER_MHZ;
}
#endif
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] xtensa: use HZ_PER_MHZ in platform_calibrate_ccount
2025-09-15 12:05 [PATCH] xtensa: use HZ_PER_MHZ in platform_calibrate_ccount Thorsten Blum
@ 2025-09-15 15:39 ` Max Filippov
0 siblings, 0 replies; 2+ messages in thread
From: Max Filippov @ 2025-09-15 15:39 UTC (permalink / raw)
To: Thorsten Blum; +Cc: Chris Zankel, linux-kernel
On Mon, Sep 15, 2025 at 5:06 AM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Replace the hardcoded 1000000UL with the HZ_PER_MHZ unit macro, and add
> a space in "10 MHz" to improve the readability of the error message.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> arch/xtensa/kernel/platform.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Thanks. Applied to my xtensa tree.
-- Max
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-15 15:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-15 12:05 [PATCH] xtensa: use HZ_PER_MHZ in platform_calibrate_ccount Thorsten Blum
2025-09-15 15:39 ` Max Filippov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox