From: David Disseldorp <ddiss@suse.de>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] initrd: Fix logged Minix/Ext2 block numbers in identify_ramdisk_image()
Date: Mon, 15 Sep 2025 12:21:46 +1000 [thread overview]
Message-ID: <20250915122146.56f66eb2.ddiss@suse.de> (raw)
In-Reply-To: <20250913103959.1788193-1-thorsten.blum@linux.dev>
Hi Thorsten,
On Sat, 13 Sep 2025 12:39:54 +0200, Thorsten Blum wrote:
> Both Minix and Ext2 filesystems are located at 'start_block + 1'. Update
> the log messages to report the correct block numbers.
I don't think this change is worthwhile. The offset of the superblock
within the filesystem image is an implementation detail.
> Replace printk(KERN_NOTICE) with pr_notice() to avoid checkpatch
> warnings.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Nothing is being fixed here.
next prev parent reply other threads:[~2025-09-15 2:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-13 10:39 [PATCH] initrd: Fix logged Minix/Ext2 block numbers in identify_ramdisk_image() Thorsten Blum
2025-09-15 2:21 ` David Disseldorp [this message]
2025-09-15 4:31 ` Darrick J. Wong
2025-09-15 10:30 ` Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915122146.56f66eb2.ddiss@suse.de \
--to=ddiss@suse.de \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox