Re: [PATCH 12/15] scsi: qla2xxx: add cmd->rsp_sent

[Dmitry Bogdanov <d.bogdanov@yadro.com>]

On Mon, Sep 08, 2025 at 03:07:04PM -0400, Tony Battersby wrote:
> 
> (target mode)
> 
> Add cmd->rsp_sent to indicate that the SCSI status has been sent
> successfully, so that SCST can be informed of any transport errors.
> This will also be used for logging in later patches.
> 
> Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
> ---
>  drivers/scsi/qla2xxx/qla_target.c | 4 ++++
>  drivers/scsi/qla2xxx/qla_target.h | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index eabb891a5528..0ddbf02ebe79 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -4067,6 +4067,10 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha,
> 
>         if (cmd->state == QLA_TGT_STATE_PROCESSED) {
>                 cmd->trc_flags |= TRC_CTIO_DONE;
> +
> +               if (likely(status == CTIO_SUCCESS))
> +                       cmd->rsp_sent = 1;

Looks like TRC_CTIO_DONE without TRC_DIF_ERR and TRC_CTIO_ERR means
exactly that CTIO was completed successfully.

> +
>         } else if (cmd->state == QLA_TGT_STATE_NEED_DATA) {
>                 cmd->state = QLA_TGT_STATE_DATA_IN;
> 
> diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h
> index 1931e1dade7a..972a7af1c81c 100644
> --- a/drivers/scsi/qla2xxx/qla_target.h
> +++ b/drivers/scsi/qla2xxx/qla_target.h
> @@ -883,6 +883,10 @@ struct qla_tgt_cmd {
>         unsigned int conf_compl_supported:1;
>         unsigned int sg_mapped:1;
>         unsigned int write_data_transferred:1;
> +
> +       /* Set if the SCSI status was sent successfully. */
> +       unsigned int rsp_sent:1;
> +
>         unsigned int q_full:1;
>         unsigned int term_exchg:1;
>         unsigned int cmd_sent_to_fw:1;
> --
> 2.43.0
> 
> 
>