From: "Onur Özkan" <work@onurozkan.dev>
To: Daniel Almeida <daniel.almeida@collabora.com>
Cc: rust-for-linux@vger.kernel.org, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
dakr@kernel.org, tamird@gmail.com, daniel@sedlak.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: less allocation in CString::try_from
Date: Mon, 15 Sep 2025 19:53:05 +0300 [thread overview]
Message-ID: <20250915195305.1309fea2@nimda.home> (raw)
In-Reply-To: <3208F1A3-CFA9-45BC-85D7-74C8C47CA11F@collabora.com>
On Mon, 15 Sep 2025 17:38:32 +0200
Daniel Almeida <daniel.almeida@collabora.com> wrote:
> Hi Onur, thanks for working on this :)
>
> The commit title doesn’t parse very well, can you rework it?
>
> — Daniel
>
>
Hi Daniel,
As Alice mentioned in [0], my assumption about reducing allocations was
wrong. Looking at the KVec implementation details this patch doesn't
actually change anything other than how the code looks. We can safely
ignore it. I should have checked that, sorry.
[0]:
https://lore.kernel.org/all/CAH5fLgi-VrhDSEjJA4Bg+5Wmr2JDAmmOc1FkfZAZ29SMqkX++w@mail.gmail.com/
Thanks,
Onur
prev parent reply other threads:[~2025-09-15 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 6:54 [PATCH] rust: less allocation in CString::try_from Onur Özkan
2025-09-15 7:26 ` Alice Ryhl
2025-09-15 7:29 ` Onur
2025-09-15 15:38 ` Daniel Almeida
2025-09-15 16:53 ` Onur Özkan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250915195305.1309fea2@nimda.home \
--to=work@onurozkan.dev \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=daniel@sedlak.dev \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox