From: Peter Zijlstra <peterz@infradead.org>
To: Menglong Dong <menglong.dong@linux.dev>
Cc: ast@kernel.org, mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, daniel@iogearbox.net,
john.fastabend@gmail.com, andrii@kernel.org,
martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me,
haoluo@google.com, jolsa@kernel.org, tzimmermann@suse.de,
simona.vetter@ffwll.ch, jani.nikula@intel.com,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH v4 2/3] sched: make migrate_enable/migrate_disable inline
Date: Tue, 16 Sep 2025 13:07:12 +0200 [thread overview]
Message-ID: <20250916110712.GI3245006@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20250828060354.57846-3-menglong.dong@linux.dev>
On Thu, Aug 28, 2025 at 02:03:53PM +0800, Menglong Dong wrote:
> +/* The "struct rq" is not available here, so we can't access the
> + * "runqueues" with this_cpu_ptr(), as the compilation will fail in
> + * this_cpu_ptr() -> raw_cpu_ptr() -> __verify_pcpu_ptr():
> + * typeof((ptr) + 0)
> + *
> + * So use arch_raw_cpu_ptr()/PERCPU_PTR() directly here.
> + */
Please fix broken comment style while you fix that compile error.
next prev parent reply other threads:[~2025-09-16 11:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 6:03 [PATCH v4 0/3] sched: make migrate_enable/migrate_disable inline Menglong Dong
2025-08-28 6:03 ` [PATCH v4 1/3] arch: add the macro COMPILE_OFFSETS to all the asm-offsets.c Menglong Dong
2025-08-28 6:03 ` [PATCH v4 2/3] sched: make migrate_enable/migrate_disable inline Menglong Dong
2025-09-16 11:07 ` Peter Zijlstra [this message]
2025-09-16 16:27 ` Alexei Starovoitov
2025-09-17 1:25 ` Menglong Dong
2025-09-17 1:29 ` Alexei Starovoitov
2025-09-17 1:30 ` Menglong Dong
2025-08-28 6:03 ` [PATCH v4 3/3] sched: fix some typos in include/linux/preempt.h Menglong Dong
2025-08-28 9:47 ` [syzbot ci] Re: sched: make migrate_enable/migrate_disable inline syzbot ci
2025-09-15 1:49 ` [PATCH v4 0/3] " Menglong Dong
2025-09-15 16:10 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250916110712.GI3245006@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=bsegall@google.com \
--cc=daniel@iogearbox.net \
--cc=dietmar.eggemann@arm.com \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=jani.nikula@intel.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=menglong.dong@linux.dev \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sdf@fomichev.me \
--cc=simona.vetter@ffwll.ch \
--cc=song@kernel.org \
--cc=tzimmermann@suse.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox