Re: [PATCH v3 05/13] mm/vma: rename __mmap_prepare() function to avoid confusion

Lorenzo Stoakes
2025-09-17T13:25:06Z

On Wed, Sep 17, 2025 at 11:49:18AM +0100, Pedro Falcato wrote:
> On Tue, Sep 16, 2025 at 03:11:51PM +0100, Lorenzo Stoakes wrote:
> > Now we have the f_op->mmap_prepare() hook, having a static function called
> > __mmap_prepare() that has nothing to do with it is confusing, so rename
> > the function to __mmap_setup().
> >
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> > Reviewed-by: David Hildenbrand <david@redhat.com>
>
> I would love to bikeshed on the new name (maybe something more descriptive?),
> but I don't really mind.

Lol thanks, I think let's get this in :P

>
> Reviewed-by: Pedro Falcato <pfalcato@suse.de>

Cheers!

>
> --
> Pedro