Re: [PATCH v6 04/21] scripts: check-variable-fonts.sh: convert to Python

[Mauro Carvalho Chehab <mchehab+huawei@kernel.org>]

Em Wed, 17 Sep 2025 10:09:05 +0900
Akira Yokosawa <akiyks@gmail.com> escreveu:

> On Tue, 16 Sep 2025 12:22:40 +0200, Mauro Carvalho Chehab wrote:
> > This script handle errors when trying to build translations
> > with make pdfdocs.
> > 
> > As part of our cleanup work to remove hacks from docs Makefile,
> > convert this to python, preparing it to be part of a library
> > to be called by sphinx-build-wrapper.
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> 
> I could apply up to 05/21 of v6 and did some quick tests under
> Fedora (where Noto CJK VF fonts are installed).
> 
> At 3/21, "./scripts/check-variable-fonts.sh" doesn't say a word.
> 
> At 4/21, "./scripts/check-variable-fonts.py" complains:

I got a little bit confused with the above. I guess you picked the
wrong patch numbers, but yeah, there is a bisect issue, caused by
the part reorder I did moving this change to happen before adding
the script. Basically, I updated docs Makefile the wrong way.

Thanks for pointing it!

For v7 I'll ensure that all patches will properly print the suggestions
from the script.

> =============================================================================
> XeTeX is confused by "variable font" files listed below:
>     /usr/share/fonts/google-noto-sans-cjk-vf-fonts/NotoSansCJK-VF.ttc
>     /usr/share/fonts/google-noto-sans-mono-cjk-vf-fonts/NotoSansMonoCJK-VF.ttc
>     /usr/share/fonts/google-noto-serif-cjk-vf-fonts/NotoSerifCJK-VF.ttc
> 
> For CJK pages in PDF, they need to be hidden from XeTeX by denylisting.
> Or, CJK pages can be skipped by uninstalling texlive-xecjk.
> 
> For more info on denylisting, other options, and variable font, see header
> comments of scripts/check-variable-fonts.py.
> =============================================================================
> 
> Of course, I have followed the suggestions in the header comments.

I didn't try to follow the suggestions to solve the issue on Fedora yet.
It is on my todo list to test it.

The new script has an exact copy of the instructions of the previous one.

So, up to patch 09/21 from this series, there won't be any change at
doc build, except for the script conversion and some code cleanups
and reordering.

Patch 09/21 moves the env logic of FONTS_CONF_DENY_VF to the wrapper.
So, in thesis, fixing it before-after the series shouldn't have any
impact (I didn't test yet. Will do on my next respin). Btw, we should
probably document it at make help.

If the instructions from the header is wrong, we need to update it
on a separate patch series.

> So I have to NAK on 4/21.
> 
> Regards,
> Akira
> 



Thanks,
Mauro