public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: 李佳怡 <lijiayi@kylinos.cn>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] thunderbolt: Re-add DP resources on resume
Date: Fri, 19 Sep 2025 10:41:21 +0200	[thread overview]
Message-ID: <20250919084121.GP2912318@black.igk.intel.com> (raw)
In-Reply-To: <0f9a0d5a-d51c-45f4-8f1c-050e7c609baa@kylinos.cn>

On Fri, Sep 19, 2025 at 04:00:48PM +0800, 李佳怡 wrote:
> > The lspci dump indicates this is ASMedia host controller. I did not even
> > know that they have such thing. I thought they only have device (which
> > should be working in Linux). The host side may require some additional
> > enablement.
> 
> Apologies, Please find the latest results.
> 
> # tbdump -vv -r 0 -N 1  -a 10 ADP_CS_5
> 0x0005 0x0000d809 0b00000000 00000000 11011000 00001001 .... ADP_CS_5
>   [00:06]        0x9 Max Input HopID
>   [11:17]       0x1b Max Output HopID
>   [22:28]        0x0 Link Credits Allocated
>   [29:29]        0x0 HEC Error Enable (HEE)
>   [30:30]        0x0 Flow Control Error Enable (FCEE)
>   [31:31]        0x0 Disable Hot Plug Events (DHP)
> 
> # tbdump -vv -r 0 -N 1  -a 11 ADP_CS_5
> 0x0005 0x0000d809 0b00000000 00000000 11011000 00001001 .... ADP_CS_5
>   [00:06]        0x9 Max Input HopID
>   [11:17]       0x1b Max Output HopID
>   [22:28]        0x0 Link Credits Allocated
>   [29:29]        0x0 HEC Error Enable (HEE)
>   [30:30]        0x0 Flow Control Error Enable (FCEE)
>   [31:31]        0x0 Disable Hot Plug Events (DHP)

Thanks! DHP bits are not set as expected.

> Regarding the ASMedia host controller: if hotplug events for the DP IN
> adapter are not being generated, is it feasible to manually add the DP IN
> resource as I initially thought, or is that approach incorrect for this
> scenario?

Well the host router exits sleep (runtime resume) and once it is being
enumerated again by the driver it is expected to send the plug events to
the DP IN adapters according to the spec. I prefer not to add things like
these if there is a standard way. Are you associated with ASMedia or you
just have a machine that has this controller? If you are then is there
possibility to talk to the hardware folks and ask if this is known issue or
perhaps it has some older firmware? I definitely like to get this working
but we should first figure out if this is some sort of known issue perhaps?

      reply	other threads:[~2025-09-19  8:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-17  8:24 [PATCH RFC] thunderbolt: Re-add DP resources on resume Jiayi Li
2025-09-17  8:36 ` Mika Westerberg
2025-09-17 10:12 ` 李佳怡
2025-09-17 12:50   ` Mika Westerberg
2025-09-18  8:34     ` 李佳怡
2025-09-18 16:20       ` Mika Westerberg
2025-09-18 16:43         ` Mika Westerberg
2025-09-19  7:24           ` 李佳怡
2025-09-19  7:30             ` Mika Westerberg
2025-09-19  8:00               ` 李佳怡
2025-09-19  8:41                 ` Mika Westerberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250919084121.GP2912318@black.igk.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=lijiayi@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox