Re: [PATCH v3 6/8] dt-bindings: soc: renesas: Add the Renesas RZ/N1 GPIO Interrupt Multiplexer

Herve Codina
2025-09-19T12:40:17Z

Hi Wolfram,

On Fri, 19 Sep 2025 11:34:51 +0200
Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:

> > + interrupt-map:
> > + description:
> > + Specifies the mapping from external GPIO interrupt lines to the output
> > + interrupts. The array items have to be ordered with the first item
> > + related to the output line 0 (IRQ 103), the next one to the output line 1
> > + (IRQ 104) and so on up to the output line 8 (IRQ 110).
>
> maxItems 8?

Yes indeed and probably both
minItems: 1
maxItems: 8

>
> > + /*
> > + * The child interrupt number is computed using the following formula:
> > + * gpio_bank * 32 + gpio_number
> > + *
> > + * with:
> > + * - gpio_bank: The GPIO bank number
> > + * - 0 for GPIO0A,
> > + * - 1 for GPIO1A,
> > + * - 2 for GPIO2A
> > + * - gpio_number: Number of the gpio in the bank (0..31)
> > + */
>
> I wonder if this comment wouldn't be better in the interrupt-map
> description above?
>

I will move in the description.

Best regards,
Hervé