Re: [PATCH] lib/crypto: Add SHA3-224, SHA3-256, SHA3-384, SHA-512, SHAKE128, SHAKE256

[kernel test robot <lkp@intel.com>]

Hi David,

kernel test robot noticed the following build warnings:

[auto build test WARNING on ebiggers/libcrypto-fixes]
[also build test WARNING on herbert-cryptodev-2.6/master herbert-crypto-2.6/master linus/master v6.17-rc6 next-20250918]
[cannot apply to ebiggers/libcrypto-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/David-Howells/lib-crypto-Add-SHA3-224-SHA3-256-SHA3-384-SHA-512-SHAKE128-SHAKE256/20250919-061024
base:   https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git libcrypto-fixes
patch link:    https://lore.kernel.org/r/3605112.1758233248%40warthog.procyon.org.uk
patch subject: [PATCH] lib/crypto: Add SHA3-224, SHA3-256, SHA3-384, SHA-512, SHAKE128, SHAKE256
config: arm-randconfig-001-20250919 (https://download.01.org/0day-ci/archive/20250919/202509191712.4MoL99fN-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250919/202509191712.4MoL99fN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509191712.4MoL99fN-lkp@intel.com/

All warnings (new ones prefixed by >>):

   lib/crypto/sha3.c: In function 'sha3_absorb_xorle':
>> lib/crypto/sha3.c:229:30: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
     229 |                 buf[woff | 7 - boff] ^= *data++;
         |                            ~~^~~~~~


vim +229 lib/crypto/sha3.c

   211	
   212	/*
   213	 * XOR in partial data that's insufficient to fill a whole block.
   214	 */
   215	static void sha3_absorb_xorle(struct sha3_ctx *ctx, const u8 *data, unsigned int len)
   216	{
   217		unsigned int partial = ctx->partial;
   218		u8 *buf = (u8 *)ctx->state.st;
   219	
   220	#ifdef __LITTLE_ENDIAN
   221		buf += partial;
   222		for (int i = 0; i < len; i++)
   223			*buf++ ^= *data++;
   224	#else
   225		for (int i = 0; i < len; i++) {
   226			unsigned int woff = (partial + i) & ~7;
   227			unsigned int boff = (partial + i) & 7;
   228	
 > 229			buf[woff | 7 - boff] ^= *data++;
   230		}
   231	#endif
   232		ctx->partial += len;
   233	}
   234	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki