From: "Jackson.lee" <jackson.lee@chipsnmedia.com>
To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
nicolas.dufresne@collabora.com, bob.beckett@collabora.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
jackson.lee@chipsnmedia.com, lafley.kim@chipsnmedia.com,
b-brnich@ti.com, hverkuil@xs4all.nl, nas.chung@chipsnmedia.com
Subject: [PATCH v5 3/4] media: chips-media: wave5: Add WARN_ON to check if dec_output_info is NULL
Date: Mon, 22 Sep 2025 14:52:54 +0900 [thread overview]
Message-ID: <20250922055255.116-4-jackson.lee@chipsnmedia.com> (raw)
In-Reply-To: <20250922055255.116-1-jackson.lee@chipsnmedia.com>
From: Jackson Lee <jackson.lee@chipsnmedia.com>
The dec_output_info should not be a null pointer, WARN_ON around it to
indicates a driver issue.
Signed-off-by: Jackson Lee <jackson.lee@chipsnmedia.com>
Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com>
---
drivers/media/platform/chips-media/wave5/wave5-vpuapi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpuapi.c b/drivers/media/platform/chips-media/wave5/wave5-vpuapi.c
index e94d6ebc9f81..5b10f9f49b9f 100644
--- a/drivers/media/platform/chips-media/wave5/wave5-vpuapi.c
+++ b/drivers/media/platform/chips-media/wave5/wave5-vpuapi.c
@@ -485,7 +485,7 @@ int wave5_vpu_dec_get_output_info(struct vpu_instance *inst, struct dec_output_i
struct vpu_device *vpu_dev = inst->dev;
struct dec_output_info *disp_info;
- if (!info)
+ if (WARN_ON(!info))
return -EINVAL;
p_dec_info = &inst->codec_info->dec_info;
--
2.43.0
next prev parent reply other threads:[~2025-09-22 5:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-22 5:52 [PATCH v5 0/4] Performance improvement of decoder Jackson.lee
2025-09-22 5:52 ` [PATCH v5 1/4] media: chips-media: wave5: Fix SError of kernel panic when closed Jackson.lee
2025-11-05 21:38 ` Brandon Brnich
2025-09-22 5:52 ` [PATCH v5 2/4] media: chips-media: wave5: Fix Null reference while testing fluster Jackson.lee
2025-09-22 5:52 ` Jackson.lee [this message]
2025-09-22 5:52 ` [PATCH v5 4/4] media: chips-media: wave5: Improve performance of decoder Jackson.lee
2025-09-22 17:32 ` Brandon Brnich
2025-09-22 18:00 ` Nicolas Dufresne
2025-09-24 1:14 ` jackson.lee
2025-09-24 13:20 ` Nicolas Dufresne
2025-09-24 15:06 ` Brandon Brnich
2025-09-23 0:57 ` jackson.lee
2025-10-27 5:38 ` [PATCH v5 0/4] Performance improvement " jackson.lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922055255.116-4-jackson.lee@chipsnmedia.com \
--to=jackson.lee@chipsnmedia.com \
--cc=b-brnich@ti.com \
--cc=bob.beckett@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=hverkuil@xs4all.nl \
--cc=lafley.kim@chipsnmedia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nas.chung@chipsnmedia.com \
--cc=nicolas.dufresne@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox