Re: [PATCH 4/9] dt-bindings: mmc: add binding for BST DWCMSHC SDHCI controller

Albert Yang
2025-10-15T09:10:07Z

Hi Rob,

Thank you for your review and feedback on v4!

On Tue, Sep 23, 2025 at 08:56:20AM -0500, Rob Herring wrote:
> On Tue, Sep 23, 2025 at 02:10:10PM +0800, Albert Yang wrote:
> > Changes for v4:
>
> Thanks for the changelog here, but the subject should have 'PATCH v4' so
> various tools work.

Acknowledged. I'll ensure the subject line follows the correct format
"[PATCH v5 X/Y]" in the next version.

> Filename should match compatible.

Agreed. I will rename the file from:
bst,dwcmshc-sdhci.yaml
to:
bst,c1200-sdhci.yaml

and update the $id field accordingly from:
http://devicetree.org/schemas/mmc/bst,dwcmshc-sdhci.yaml#
to:
http://devicetree.org/schemas/mmc/bst,c1200-sdhci.yaml#

> > + clock-names:
> > + items:
> > + - const: core
>
> Not really any point in having -names when there is only 1 entry.> Not really any point in having -names when there is only 1 entry.

You're right. I'll remove the clock-names property and its entry from the
required properties list.

> > + memory-region:
> > + maxItems: 1
>
> Having this is odd. Please add a description saying what it is for.
>> Having this is odd. Please add a description saying what it is for.

I'll add a description for memory-region:

memory-region:
maxItems: 1
description:
Phandle to a reserved memory region for DMA bounce buffer. The BST C1200
SDHCI controller supports only 32-bit DMA addressing, while system memory
may be located above 4GB address space.

Additionally, I've already corrected the example's compatible string from
"bst,c1200-dwcmshc-sdhci" to "bst,c1200-sdhci" to match the property definition.

I'll prepare v5 with all the above changes addressed.

Best regards,
Albert Yang