Re: [PATCH 4/9] dt-bindings: mmc: add binding for BST DWCMSHC SDHCI controller

Albert Yang
2025-10-15T09:46:23Z

Hi Rob,

Thank you for running the dt_binding_check on this patch!

On Tue, Sep 23, 2025 at 05:13:09AM -0500, Rob Herring (Arm) wrote:
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/mmc/bst,dwcmshc-sdhci.example.dtb: /example-0/bus/mmc@22200000: failed to match any schema with compatible: ['bst,c1200-dwcmshc-sdhci']

This error occurred because in v4, while I updated the dts compatible property
definition to "bst,c1200-sdhci" (as requested in review), I failed to update
the compatible string in the example node accordingly. The example was still
using the old "bst,c1200-dwcmshc-sdhci", causing the schema validation to fail.

I have now corrected the example's compatible string from:
compatible = "bst,c1200-dwcmshc-sdhci";
to:
compatible = "bst,c1200-sdhci";

Following your suggestion, I've upgraded dtschema:
pip3 install dtschema --upgrade

and verified the fix with:
make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/bst,c1200-sdhci.yaml

The binding now passes all validation checks. This fix will be included in v5.

Best regards,
Albert Yang