From: Jason Gunthorpe <jgg@nvidia.com>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: nicolinc@nvidia.com, linux-kernel@vger.kernel.org,
robin.murphy@arm.com, will@kernel.org, joro@8bytes.org,
kevin.tian@intel.com, jsnitsel@redhat.com, vasant.hegde@amd.com,
iommu@lists.linux.dev, santosh.shukla@amd.com,
sairaj.arunkodilkar@amd.com, jon.grimm@amd.com,
prashanthpra@google.com, wvw@google.com, wnliu@google.com,
gptran@google.com, kpsingh@google.com
Subject: Re: [PATCH v4] iommu/amd: Add support for hw_info for iommu capability query
Date: Tue, 23 Sep 2025 14:55:51 -0300 [thread overview]
Message-ID: <20250923175551.GB2617119@nvidia.com> (raw)
In-Reply-To: <20250904193112.7418-1-suravee.suthikulpanit@amd.com>
On Thu, Sep 04, 2025 at 07:31:12PM +0000, Suravee Suthikulpanit wrote:
> AMD IOMMU Extended Feature (EFR) and Extended Feature 2 (EFR2) registers
> specify features supported by each IOMMU hardware instance.
> The IOMMU driver checks each feature-specific bits before enabling
> each feature at run time.
>
> For IOMMUFD, the hypervisor passes the raw value of amd_iommu_efr and
> amd_iommu_efr2 to VMM via iommufd IOMMU_DEVICE_GET_HW_INFO ioctl.
>
> Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> ---
> Change in v4:
> * Add CONFIG_AMD_IOMMU_IOMMUFD
> * Update comment regarding EFR/EFR2 from struct iommu_hw_info_amd.
>
> Change in v3:
> * Remove extern
> * Fix link to IOMMU spec
> * Update kdoc
>
> Change in v2:
> * Do not mask the EFR/EFR2 and simply return the value reported by hardware
> * Move amd_iommufd_hw_info() to drivers/iommu/amd/iommufd.c
> * Also support IOMMU_HW_INFO_TYPE_DEFAULT
>
> drivers/iommu/amd/Kconfig | 10 ++++++++++
> drivers/iommu/amd/Makefile | 1 +
> drivers/iommu/amd/iommu.c | 2 ++
> drivers/iommu/amd/iommufd.c | 31 +++++++++++++++++++++++++++++++
> drivers/iommu/amd/iommufd.h | 15 +++++++++++++++
> include/uapi/linux/iommufd.h | 28 ++++++++++++++++++++++++++++
> 6 files changed, 87 insertions(+)
> create mode 100644 drivers/iommu/amd/iommufd.c
> create mode 100644 drivers/iommu/amd/iommufd.h
There was a kbuild issue so this needs to be resent, but
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
prev parent reply other threads:[~2025-09-23 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 19:31 [PATCH v4] iommu/amd: Add support for hw_info for iommu capability query Suravee Suthikulpanit
2025-09-09 2:23 ` kernel test robot
2025-09-11 16:58 ` Vasant Hegde
2025-09-23 17:55 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250923175551.GB2617119@nvidia.com \
--to=jgg@nvidia.com \
--cc=gptran@google.com \
--cc=iommu@lists.linux.dev \
--cc=jon.grimm@amd.com \
--cc=joro@8bytes.org \
--cc=jsnitsel@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kpsingh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=prashanthpra@google.com \
--cc=robin.murphy@arm.com \
--cc=sairaj.arunkodilkar@amd.com \
--cc=santosh.shukla@amd.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
--cc=wnliu@google.com \
--cc=wvw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox