Re: [PATCH 1/3] objtool/x86: Remove 0xea hack

Alexandre Chartre
2025-09-25T09:56:06Z

On 9/24/25 15:45, Peter Zijlstra wrote:
> Was properly fixed in the decoder with commit 4b626015e1bf ("x86/insn:
> Stop decoding i64 instructions in x86-64 mode at opcode")
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
> tools/objtool/arch/x86/decode.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> --- a/tools/objtool/arch/x86/decode.c
> +++ b/tools/objtool/arch/x86/decode.c
> @@ -189,15 +189,6 @@ int arch_decode_instruction(struct objto
> op2 = ins.opcode.bytes[1];
> op3 = ins.opcode.bytes[2];
>
> - /*
> - * XXX hack, decoder is buggered and thinks 0xea is 7 bytes long.
> - */
> - if (op1 == 0xea) {
> - insn->len = 1;
> - insn->type = INSN_BUG;
> - return 0;
> - }
> -
> if (ins.rex_prefix.nbytes) {
> rex = ins.rex_prefix.bytes[0];
> rex_w = X86_REX_W(rex) >> 3;
>
>

Reviewed-by: Alexandre Chartre <alexandre.chartre@oracle.com>

alex.