From: "Theodore Ts'o" <tytso@mit.edu>
To: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: linux-ext4@vger.kernel.org,
Ritesh Harjani <ritesh.list@gmail.com>,
Zhang Yi <yi.zhang@huawei.com>,
linux-kernel@vger.kernel.org,
"Darrick J . Wong" <djwong@kernel.org>
Subject: Re: [PATCH 2/2] fsmap: use blocksize units instead of cluster units
Date: Fri, 26 Sep 2025 08:35:36 -0400 [thread overview]
Message-ID: <20250926123536.GA12175@mit.edu> (raw)
In-Reply-To: <d332ed2f90a0c8533139741d25e7fc1935773e14.1757058211.git.ojaswin@linux.ibm.com>
On Fri, Sep 05, 2025 at 01:44:47PM +0530, Ojaswin Mujoo wrote:
> Currently, ext4's implementation of fsmap converts the ranges to cluster
> units if bigalloc is enabled and then converts to block units whenever
> needed. However, this back and forth conversion has known to cause
> several edge case issues since even with bigalloc the metadata is still
> in block size unit....
This commit causes ext4/028 to fail with a 1k blocksize. The failure
happens after just under 45 minutes; before this commit, ext4/028
would complete after a second.
Do you have a preference regarding whether I just drop this commit, or
drop the whole series? The previous patch looks fine to me and fixes
a real problem, so my plan is to keep the 1/2 commit and drop this
one.
Cheers,
- Ted
next prev parent reply other threads:[~2025-09-26 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 8:14 [PATCH 0/2] Some more misc fsmap fixes Ojaswin Mujoo
2025-09-05 8:14 ` [PATCH 1/2] ext4: Correctly handle queries for metadata mappings Ojaswin Mujoo
2025-09-05 8:14 ` [PATCH 2/2] fsmap: use blocksize units instead of cluster units Ojaswin Mujoo
2025-09-26 12:35 ` Theodore Ts'o [this message]
2025-10-02 17:42 ` Ojaswin Mujoo
2025-09-26 21:47 ` [PATCH 0/2] Some more misc fsmap fixes Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250926123536.GA12175@mit.edu \
--to=tytso@mit.edu \
--cc=djwong@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox