linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Akshay Jindal <akshayaj.lkd@gmail.com>
Cc: dan@dlrobertson.com, dlechner@baylibre.com, nuno.sa@analog.com,
	andy@kernel.org, shuah@kernel.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: accel: bma400: Refactor generic interrupt configuration
Date: Sun, 28 Sep 2025 10:12:41 +0100	[thread overview]
Message-ID: <20250928101241.27a51491@jic23-huawei> (raw)
In-Reply-To: <CAE3SzaRfeU9E78YNCofjgRZf76pDFEGxDdA9XwTF2_WAb8zj4Q@mail.gmail.com>

On Sun, 28 Sep 2025 00:13:46 +0530
Akshay Jindal <akshayaj.lkd@gmail.com> wrote:

> On Thu, Sep 25, 2025 at 10:39 PM Akshay Jindal <akshayaj.lkd@gmail.com> wrote:
> >
> > Refactor generic interrupt configuration to replace hard-coded
> > register values with logical macros and enums, thereby making the
> > configuration understandable and in-style with common kernel
> > patterns.
> >
> > Introduce a const struct with a helper to map event direction to the
> > corresponding generic interrupt and sanitize the input before use.
> >
> > Rename activity_event_en() to generic_event_en() to better describe
> > its role in activity and inactivity detection.
> >
> > No functional changes done.
> >
> > Signed-off-by: Akshay Jindal <akshayaj.lkd@gmail.com>
> > ---

> Hello Reviewers,
> After waiting for a week, I have sent v2.
> Requesting your valuable feedback on this.
Hi Akshay,

Really minor process thing.

Even for a request like this, which should have been under the --- in the original
post of v2, crop the content to what matters.

Also, no need to say this at all really!  You waited a reasonable amount of time
given you had some reviews in during that week, and the rest of the comment
is kind of obvious.

So this reply mostly added noise to a busy review queue!

Jonathan


> 
> Thanks,
> Akshay.


  reply	other threads:[~2025-09-28  9:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25 17:09 [PATCH v2] iio: accel: bma400: Refactor generic interrupt configuration Akshay Jindal
2025-09-27 18:43 ` Akshay Jindal
2025-09-28  9:12   ` Jonathan Cameron [this message]
2025-09-28  9:44 ` Jonathan Cameron
2025-10-02 19:00   ` Akshay Jindal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250928101241.27a51491@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=akshayaj.lkd@gmail.com \
    --cc=andy@kernel.org \
    --cc=dan@dlrobertson.com \
    --cc=dlechner@baylibre.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).