From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CD512ED866; Mon, 29 Sep 2025 09:54:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759139671; cv=none; b=fCvtsahD6r6+6+v3itXfqZbNdVxpuDb0xayOgGSw/Bndz/OJNl65MyqJp9Xr6kywMDC7o80Ybl0RBaNjOgd9jGF0H5NJU7+ooHQ4tbMYljPLdeoHzr/606eC3vKRnOjWdbvD1blDQvWYE7TpczwLBmSXcs2gMxnBa4ft5l3ND5g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759139671; c=relaxed/simple; bh=lDn9F5tx2ppP7pvI0PEL6bF9L5E+LPHwI3GzH2Xe9BQ=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SS2NjxDUwvAXmh8lbx0jJXk/c6Qyz80Qo/i8KEpT+mvAfuHFM8ms9tofciUcP2nDj2dptiU5X6vw8uJ0D5ZZx2K5BYJC+DD6O/yHJflVsvo5VB5UU0XhOaXyXIbbOXOol3XtmEfL5p+HXeQxDUhjUZ92xCeGozcbeyn016lEKVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4cZxNm4wjsz6L52D; Mon, 29 Sep 2025 17:54:16 +0800 (CST) Received: from dubpeml100005.china.huawei.com (unknown [7.214.146.113]) by mail.maildlp.com (Postfix) with ESMTPS id 25BDE1402FE; Mon, 29 Sep 2025 17:54:27 +0800 (CST) Received: from localhost (10.47.64.220) by dubpeml100005.china.huawei.com (7.214.146.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 29 Sep 2025 10:54:25 +0100 Date: Mon, 29 Sep 2025 10:54:24 +0100 From: Jonathan Cameron To: Sakari Ailus CC: , , , , , , , "Rafael J. Wysocki" , "Len Brown" , Greg Kroah-Hartman , Danilo Krummrich , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Javier Carrasco , Dmitry Torokhov , Lee Jones , Pavel Machek , Matthias Fend , Chanwoo Choi , Krzysztof Kozlowski , "Laurent Pinchart" , Paul Elder , Mauro Carvalho Chehab , Horatiu Vultur , , Andrew Lunn , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Mark Brown , Thomas Gleixner , Ingo Molnar Subject: Re: [PATCH v2 16/16] spi: cadence: Remove explicit device node availability check Message-ID: <20250929105424.00007069@huawei.com> In-Reply-To: <20250924074602.266292-17-sakari.ailus@linux.intel.com> References: <20250924074602.266292-1-sakari.ailus@linux.intel.com> <20250924074602.266292-17-sakari.ailus@linux.intel.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100012.china.huawei.com (7.191.174.184) To dubpeml100005.china.huawei.com (7.214.146.113) On Wed, 24 Sep 2025 10:46:02 +0300 Sakari Ailus wrote: > Don't check the availability of child device nodes explicitly as this is > now embedded in device_for_each_child_node(). > > Signed-off-by: Sakari Ailus Reviewed-by: Jonathan Cameron > --- > drivers/spi/spi-cadence-xspi.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/spi/spi-cadence-xspi.c b/drivers/spi/spi-cadence-xspi.c > index 6dcba0e0ddaa..23e426ef9b9c 100644 > --- a/drivers/spi/spi-cadence-xspi.c > +++ b/drivers/spi/spi-cadence-xspi.c > @@ -908,9 +908,6 @@ static int cdns_xspi_of_get_plat_data(struct platform_device *pdev) > unsigned int cs; > > device_for_each_child_node(&pdev->dev, fwnode_child) { > - if (!fwnode_device_is_available(fwnode_child)) > - continue; > - > if (fwnode_property_read_u32(fwnode_child, "reg", &cs)) { > dev_err(&pdev->dev, "Couldn't get memory chip select\n"); > fwnode_handle_put(fwnode_child);