From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux PM <linux-pm@vger.kernel.org>, Takashi Iwai <tiwai@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>,
"Alex Williamson" <alex.williamson@redhat.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Zhang Qilong <zhangqilong3@huawei.com>,
Ulf Hansson <ulf.hansson@linaro.org>, Frank Li <Frank.Li@nxp.com>,
Dhruva Gole <d-gole@ti.com>
Subject: Re: [PATCH v4 0/3] PM: runtime: Auto-cleanup macros for runtime PM
Date: Mon, 29 Sep 2025 12:15:25 +0100 [thread overview]
Message-ID: <20250929121525.00001775@huawei.com> (raw)
In-Reply-To: <6196611.lOV4Wx5bFT@rafael.j.wysocki>
On Fri, 26 Sep 2025 17:40:29 +0200
"Rafael J. Wysocki" <rafael@kernel.org> wrote:
> Hi All,
>
> This supersedes
>
> https://lore.kernel.org/linux-pm/12763087.O9o76ZdvQC@rafael.j.wysocki/
>
> which was an update of
>
> https://lore.kernel.org/linux-pm/6204724.lOV4Wx5bFT@rafael.j.wysocki/
>
> that superseded both
>
> https://lore.kernel.org/linux-pm/5049058.31r3eYUQgx@rafael.j.wysocki/
>
> and
>
> https://lore.kernel.org/linux-pm/20250919163147.4743-1-tiwai@suse.de/
>
> It follows the Jonathan's suggestion to use ACQUIRE()/ACQUIRE_ERR()
> instead af raw CLASS() to make the code somewhat cleaner.
>
> Thanks!
Looks excellent to me. I've already been pointing a few people at this
in driver reviews, so I expect to see a lot of adoption in IIO (and elsewhere).
That RPM_TRANSPARENT handling is particularly nice.
With the tweaks you've already called out.
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Given timing, if this ends up as a next cycle thing please could we have
an immutable branch? If it is going to make the merge window then no need.
Thanks,
Jonathan
next prev parent reply other threads:[~2025-09-29 11:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 15:40 [PATCH v4 0/3] PM: runtime: Auto-cleanup macros for runtime PM Rafael J. Wysocki
2025-09-26 15:47 ` [PATCH v4 1/3] PM: runtime: Add auto-cleanup macros for "resume and get" operations Rafael J. Wysocki
2025-09-26 19:48 ` dan.j.williams
2025-09-26 19:56 ` Rafael J. Wysocki
2025-09-29 13:24 ` Dhruva Gole
2025-09-26 16:24 ` [PATCH v4 2/3] PCI/sysfs: Use runtime PM guard macro for auto-cleanup Rafael J. Wysocki
2025-10-20 22:07 ` Farhan Ali
2025-10-21 12:44 ` Rafael J. Wysocki
2025-09-26 16:26 ` [PATCH v4 3/3] PM: runtime: Drop DEFINE_FREE() for pm_runtime_put() Rafael J. Wysocki
2025-09-26 16:48 ` Rafael J. Wysocki
2025-09-27 7:55 ` [PATCH v4 0/3] PM: runtime: Auto-cleanup macros for runtime PM Takashi Iwai
2025-09-29 11:15 ` Jonathan Cameron [this message]
2025-09-29 13:59 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250929121525.00001775@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Frank.Li@nxp.com \
--cc=alex.williamson@redhat.com \
--cc=d-gole@ti.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tiwai@suse.de \
--cc=ulf.hansson@linaro.org \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox