From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC3F523D7E3 for ; Mon, 29 Sep 2025 21:17:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759180673; cv=none; b=dimVJG9pK4n1agjNZBw2QLne0e0s8sdhmZubeywCbpYMB5MiAyyESxSi+LTA/TBZ5SoZC/jUi+JtKR4wBAPcrohpX+LrvZkebeDYGS/M4HG9TKHpyNtUk6uXN02oL9Uyp/WOe9Z3s5rRxIJnje8TaDhq7HjfCMITcBEdVx6BZ18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759180673; c=relaxed/simple; bh=0oSgxEnNwZj0iK2MMd9XdDjcPgJYwsCBsAngjqYdLuk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FnjYJ23tARqBze07giFVjEM9OaRGcCBIghOdrC5lIMXamYdbUW/m96mA3lBw2WV9lDionmwDPhkFkjI/G8kApE8cQIsHkg7sGi/uxiyBO15UAEcZ1bbRv7LViFAxN0ER0IXaxg+aF5ZrBGURqnSKj3R4jB/wXU4bHGFfka1D6ww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eSzIvrH3; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eSzIvrH3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759180670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pary30BmU4/NqakwYdG1eNkY0RiL1NyFW4TmIsuJ5GE=; b=eSzIvrH3TgR0u/E7xT35nD+af8z61fl3d06j8oab4bPnIAOmHnplVN848Li+daD8aG2NUl eo9ppaNIkhWD0cfULhpqQAOKXbhi3NB/3F3Q77eGKJqGllFgASG+czUoRAp9Mk3BRKkKmM PaGkjgchT4tV6RFaWyNW7XHFmxsUftE= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-435-5UK46Du8NkSrXLKRoXUzVQ-1; Mon, 29 Sep 2025 17:17:49 -0400 X-MC-Unique: 5UK46Du8NkSrXLKRoXUzVQ-1 X-Mimecast-MFC-AGG-ID: 5UK46Du8NkSrXLKRoXUzVQ_1759180668 Received: by mail-il1-f199.google.com with SMTP id e9e14a558f8ab-427350656e3so6835585ab.1 for ; Mon, 29 Sep 2025 14:17:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759180668; x=1759785468; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pary30BmU4/NqakwYdG1eNkY0RiL1NyFW4TmIsuJ5GE=; b=smAeNJtdKLfyC0wTrXFbHL3RVwhbznB0GOhBRih6LPP4iSQNimmW2eycOMdSx2lpJf ksB8yGDc029qBkrbplGW0KI9seTXRqYilRfb2O+bUV49qbQzuLEpldWdn/ltpfQd8go2 g+84SElRjCcqqPt/EN4eIWu1VqQqzqdnJ+xjjFG44a5b1TcKrLbLaDVe00Aw5nW5XqBE CY0tAu4An+d5+ieBp4CuuN/YISErqEaVcSJDSMlX8S6wS8H+IyO2jLDQJ//AqPd1wLfg /i9B0pRlQ6h5Cgh8OkVQfOL/PzcopXE1PPPxYfwQp/n9yl6n+p/b4PCrrQtjiSeXUvsV QXkg== X-Forwarded-Encrypted: i=1; AJvYcCW9aohxbAlA8a3SnbA7QyOiYfayEwnasMIAIuuJ2rjnSE68OI+0LKupy84kUkGxYIBhmyUMtcrEVO8Nuiw=@vger.kernel.org X-Gm-Message-State: AOJu0YzMT8Svk9MDkiRq9aCv2w13v+dK9jYnZEVs0RID1rPTWjizidtY qaKdYmGcTTLwTLn3Wd4BPZbxnUgxLGu05Mw7pZU8ZJXBdqdwMX1NJz5jz9YQCUNr4qq0dPyCzR7 Kr+Kj04OpjxjRUOSj1yz60k3dHO3KPnsn7ke1ppYekKoCQTc0/aYpZqvMzXwS+9kkrQ== X-Gm-Gg: ASbGncufNWr1aRbhFavguwH9lqY2D3ZQZtGqroDybFgAWPYHIEUmOkXpQZOArrQyUBM /H/uDrIYKcImYDahynGm7CcKAiu5p5w/8R7Mv91b9kJTl6wIMfQK2Q3SmMFWhxiflgtZgLkyNSo Xm6ZAYrF58z6Pf+WBHrOPU0/LRoqTpVfR9g2LCnyE6oHxNkp7wk10+Y6VhCghnAnNNVJtFEeC6H ZB3EcK0OMHSPryhG0AtiXoZkInG8zXbHZisqdUOcTvD13kG4d4AtagQFp0uYYcZgTBauWthpzES li4LvWJbW9sPiwyHwXuYc5zdq3zbI86LFF2DxY3NCSc= X-Received: by 2002:a05:6e02:1b08:b0:424:6c8e:6187 with SMTP id e9e14a558f8ab-425955e4dfdmr95833885ab.2.1759180668398; Mon, 29 Sep 2025 14:17:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHE31/4ZuuqxcHY5C8RvKg6dnDpxm6QWjHiIpet9IRXNGlsIsGmjCxy18kHCIW8dgbK0MWZ9w== X-Received: by 2002:a05:6e02:1b08:b0:424:6c8e:6187 with SMTP id e9e14a558f8ab-425955e4dfdmr95833605ab.2.1759180667942; Mon, 29 Sep 2025 14:17:47 -0700 (PDT) Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5753c50a188sm920778173.31.2025.09.29.14.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Sep 2025 14:17:46 -0700 (PDT) Date: Mon, 29 Sep 2025 15:17:45 -0600 From: Alex Williamson To: Leon Romanovsky Cc: Leon Romanovsky , Jason Gunthorpe , Andrew Morton , Bjorn Helgaas , Christian =?UTF-8?B?S8O2bmln?= , dri-devel@lists.freedesktop.org, iommu@lists.linux.dev, Jens Axboe , Joerg Roedel , kvm@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Logan Gunthorpe , Marek Szyprowski , Robin Murphy , Sumit Semwal , Vivek Kasireddy , Will Deacon Subject: Re: [PATCH v4 08/10] vfio/pci: Enable peer-to-peer DMA transactions by default Message-ID: <20250929151745.439be1ec.alex.williamson@redhat.com> In-Reply-To: References: X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 28 Sep 2025 17:50:18 +0300 Leon Romanovsky wrote: > From: Leon Romanovsky > > Make sure that all VFIO PCI devices have peer-to-peer capabilities > enables, so we would be able to export their MMIO memory through DMABUF, > > Signed-off-by: Leon Romanovsky > --- > drivers/vfio/pci/vfio_pci_core.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c > index 7dcf5439dedc..608af135308e 100644 > --- a/drivers/vfio/pci/vfio_pci_core.c > +++ b/drivers/vfio/pci/vfio_pci_core.c > @@ -28,6 +28,9 @@ > #include > #include > #include > +#ifdef CONFIG_VFIO_PCI_DMABUF > +#include > +#endif > #if IS_ENABLED(CONFIG_EEH) > #include > #endif > @@ -2085,6 +2088,7 @@ int vfio_pci_core_init_dev(struct vfio_device *core_vdev) > { > struct vfio_pci_core_device *vdev = > container_of(core_vdev, struct vfio_pci_core_device, vdev); > + int __maybe_unused ret; > > vdev->pdev = to_pci_dev(core_vdev->dev); > vdev->irq_type = VFIO_PCI_NUM_IRQS; > @@ -2094,6 +2098,11 @@ int vfio_pci_core_init_dev(struct vfio_device *core_vdev) > INIT_LIST_HEAD(&vdev->dummy_resources_list); > INIT_LIST_HEAD(&vdev->ioeventfds_list); > INIT_LIST_HEAD(&vdev->sriov_pfs_item); > +#ifdef CONFIG_VFIO_PCI_DMABUF > + ret = pcim_p2pdma_init(vdev->pdev); > + if (ret) > + return ret; > +#endif > init_rwsem(&vdev->memory_lock); > xa_init(&vdev->ctx); > What breaks if we don't test the return value and remove all the #ifdefs? The feature call should fail if we don't have a provider but that seems more robust than failing to register the device. Thanks, Alex