From: "Loïc Molinari" <loic.molinari@collabora.com>
To: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"Boris Brezillon" <boris.brezillon@collabora.com>,
"Rob Herring" <robh@kernel.org>,
"Steven Price" <steven.price@arm.com>,
"Liviu Dudau" <liviu.dudau@arm.com>,
"Melissa Wen" <mwen@igalia.com>,
"Maíra Canal" <mcanal@igalia.com>,
"Hugh Dickins" <hughd@google.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Loïc Molinari" <loic.molinari@collabora.com>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Mikołaj Wasiak" <mikolaj.wasiak@intel.com>,
"Christian Brauner" <brauner@kernel.org>,
"Nitin Gote" <nitin.r.gote@intel.com>,
"Andi Shyti" <andi.shyti@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, linux-mm@kvack.org,
kernel@collabora.com
Subject: [PATCH 4/8] drm/i915: Use huge tmpfs mount point helpers
Date: Mon, 29 Sep 2025 22:03:12 +0200 [thread overview]
Message-ID: <20250929200316.18417-5-loic.molinari@collabora.com> (raw)
In-Reply-To: <20250929200316.18417-1-loic.molinari@collabora.com>
Make use of the new drm_gem_shmem_huge_mnt_create() and
drm_gem_shmem_huge_mnt_free() helpers to avoid code duplication.
Signed-off-by: Loïc Molinari <loic.molinari@collabora.com>
---
drivers/gpu/drm/i915/gem/i915_gemfs.c | 33 +++------------------------
1 file changed, 3 insertions(+), 30 deletions(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gemfs.c b/drivers/gpu/drm/i915/gem/i915_gemfs.c
index a09e2eb47175..70563a6a0b81 100644
--- a/drivers/gpu/drm/i915/gem/i915_gemfs.c
+++ b/drivers/gpu/drm/i915/gem/i915_gemfs.c
@@ -3,25 +3,13 @@
* Copyright © 2017 Intel Corporation
*/
-#include <linux/fs.h>
-#include <linux/mount.h>
-#include <linux/fs_context.h>
-
#include "i915_drv.h"
#include "i915_gemfs.h"
#include "i915_utils.h"
-static int add_param(struct fs_context *fc, const char *key, const char *val)
-{
- return vfs_parse_fs_string(fc, key, val, strlen(val));
-}
-
void i915_gemfs_init(struct drm_i915_private *i915)
{
- struct file_system_type *type;
- struct fs_context *fc;
struct vfsmount *gemfs;
- int ret;
/*
* By creating our own shmemfs mountpoint, we can pass in
@@ -38,23 +26,8 @@ void i915_gemfs_init(struct drm_i915_private *i915)
if (GRAPHICS_VER(i915) < 11 && !i915_vtd_active(i915))
return;
- if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE))
- goto err;
-
- type = get_fs_type("tmpfs");
- if (!type)
- goto err;
-
- fc = fs_context_for_mount(type, SB_KERNMOUNT);
- if (IS_ERR(fc))
- goto err;
- ret = add_param(fc, "source", "tmpfs");
- if (!ret)
- ret = add_param(fc, "huge", "within_size");
- if (!ret)
- gemfs = fc_mount_longterm(fc);
- put_fs_context(fc);
- if (ret)
+ gemfs = drm_gem_shmem_huge_mnt_create("within_size");
+ if (IS_ERR(gemfs))
goto err;
i915->mm.gemfs = gemfs;
@@ -70,5 +43,5 @@ void i915_gemfs_init(struct drm_i915_private *i915)
void i915_gemfs_fini(struct drm_i915_private *i915)
{
- kern_unmount(i915->mm.gemfs);
+ drm_gem_shmem_huge_mnt_free(i915->mm.gemfs);
}
--
2.47.3
next prev parent reply other threads:[~2025-09-29 20:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 20:03 [PATCH 0/8] drm: Optimize page tables overhead with THP Loïc Molinari
2025-09-29 20:03 ` [PATCH 1/8] drm/shmem-helper: Add huge page fault handler Loïc Molinari
2025-09-29 20:03 ` [PATCH 2/8] drm/gem: Introduce drm_gem_get_unmapped_area() fop Loïc Molinari
2025-09-30 10:05 ` kernel test robot
2025-09-30 10:30 ` Boris Brezillon
2025-09-30 10:45 ` Boris Brezillon
2025-09-30 16:09 ` Loïc Molinari
2025-09-30 16:29 ` Boris Brezillon
2025-09-30 16:42 ` Loïc Molinari
2025-09-29 20:03 ` [PATCH 3/8] drm/shmem-helper: Add huge tmpfs mount point helpers Loïc Molinari
2025-09-30 10:57 ` Boris Brezillon
2025-09-29 20:03 ` Loïc Molinari [this message]
2025-09-30 11:06 ` [PATCH 4/8] drm/i915: Use " kernel test robot
2025-09-29 20:03 ` [PATCH 5/8] drm/v3d: " Loïc Molinari
2025-09-29 20:03 ` [PATCH 6/8] drm/panthor: Introduce huge tmpfs mount point option Loïc Molinari
2025-09-30 10:34 ` Boris Brezillon
2025-09-30 16:31 ` Loïc Molinari
2025-09-30 16:52 ` Boris Brezillon
2025-10-04 9:39 ` Loïc Molinari
2025-09-30 10:36 ` kernel test robot
2025-09-29 20:03 ` [PATCH 7/8] drm/panthor: Improve IOMMU map/unmap debugging logs Loïc Molinari
2025-09-30 10:37 ` Boris Brezillon
2025-09-29 20:03 ` [PATCH 8/8] drm/panfrost: Introduce huge tmpfs mount point option Loïc Molinari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250929200316.18417-5-loic.molinari@collabora.com \
--to=loic.molinari@collabora.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi.shyti@linux.intel.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=boris.brezillon@collabora.com \
--cc=brauner@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hughd@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=mikolaj.wasiak@intel.com \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=nitin.r.gote@intel.com \
--cc=robh@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox