Re: [RFC 2/5] dt-bindings: pinctrl: add pic64gx "gpio2" pinmux

Conor Dooley
2025-10-01T15:48:08Z

[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]

On Wed, Oct 01, 2025 at 04:47:12PM +0100, Conor Dooley wrote:
> On Wed, Oct 01, 2025 at 01:32:37PM +0200, Linus Walleij wrote:
> > On Fri, Sep 26, 2025 at 4:33 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > > pin role (1/0)
> > > --- ----------
> > > E14 MAC_0_MDC/GPIO_2_0
> > > E15 MAC_0_MDIO/GPIO_2_1
> > > F16 MAC_1_MDC/GPIO_2_2
> > > F17 MAC_1_MDIO/GPIO_2_3
> >
> > So this is a group you can name "mac_grp" and a function
> > you can name "mac".
> >
> > > D19 SPI_0_CLK/GPIO_2_4
> > > B18 SPI_0_SS0/GPIO_2_5
> > (...)
> > > E19 SPI_0_DO/GPIO_2_10
> > > C7 SPI_0_DI/GPIO_2_11
> >
> > These pins would be "spi0_grp", function "spi0".
> >
> > etc. No need for "pinmux" properties just use classix
> > group and function strings.
>
> tbh, I found it hard to understand the "line" between using a pinmux
> property and where stuff should be described in groups or functions in a
> driver. What is that line?

You may have noticed that I never really review pinctrl bindings, and it
is the lack of experience with this kind of decision that's why I never
do it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]