Re: [RFC 3/5] pinctrl: add polarfire soc iomux0 pinmux driver

Linus Walleij
2025-10-01T11:34:37Z

On Fri, Sep 26, 2025 at 4:33 PM Conor Dooley <conor@kernel.org> wrote:

> +static const struct pinctrl_pin_desc mpfs_iomux0_pinctrl_pins[] = {
> + PINCTRL_PIN(0, "spi0"),
> + PINCTRL_PIN(1, "spi1"),
> + PINCTRL_PIN(2, "i2c0"),
> + PINCTRL_PIN(3, "i2c1"),
> + PINCTRL_PIN(4, "can0"),
> + PINCTRL_PIN(5, "can1"),
> + PINCTRL_PIN(6, "qspi"),
> + PINCTRL_PIN(7, "uart0"),
> + PINCTRL_PIN(8, "uart1"),
> + PINCTRL_PIN(9, "uart2"),
> + PINCTRL_PIN(10, "uart3"),
> + PINCTRL_PIN(11, "uart4"),
> + PINCTRL_PIN(12, "mdio0"),
> + PINCTRL_PIN(13, "mdio1"),

This looks like it is abusing the API. These things do not look like
"pins" at all, rather these are all groups, right?

Yours,
Linus Walleij