From: Eric Biggers <ebiggers@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: gregkh@linuxfoundation.org, sashal@kernel.org,
stable@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Ard Biesheuvel <ardb@kernel.org>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com,
Michael van der Westhuizen <rmikey@meta.com>,
Tobias Fleig <tfleig@meta.com>
Subject: Re: [PATCH] stable: crypto: sha256 - fix crash at kexec
Date: Wed, 1 Oct 2025 09:54:55 -0700 [thread overview]
Message-ID: <20251001165455.GF1592@sol> (raw)
In-Reply-To: <jm3bk53sqkqv6eg7rekzhn6bgld5byhkmksdjyxmrkifku2dmc@w7xnklqsrpee>
On Wed, Oct 01, 2025 at 09:45:07AM -0700, Breno Leitao wrote:
> Hello Eric,
>
> On Wed, Oct 01, 2025 at 09:23:05AM -0700, Eric Biggers wrote:
>
> > This looks fine, but technically 'unsigned int' would be more
> > appropriate here, given the context. If we look at the whole function
> > in 6.12, we can see that it took an 'unsigned int' length:
>
> Ack. Do you want me to send a v2 with `unsigned int` instead?
>
Sure. Could you also make it clear which kernel version(s) you are
expecting the patch to be applied to? Is it everything 5.4 through
6.15? It looks like this bug actually got exposed by f4da7afe07523f
("kexec_file: increase maximum file size to 4G") in 6.0. But
backporting to older versions should be fine too, if it applies to them.
- Eric
next prev parent reply other threads:[~2025-10-01 16:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 16:07 [PATCH] stable: crypto: sha256 - fix crash at kexec Breno Leitao
2025-10-01 16:23 ` Eric Biggers
2025-10-01 16:45 ` Breno Leitao
2025-10-01 16:54 ` Eric Biggers [this message]
2025-10-02 10:02 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251001165455.GF1592@sol \
--to=ebiggers@kernel.org \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmikey@meta.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tfleig@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox