public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Eugenio Pérez" <eperezma@redhat.com>
To: mst@redhat.com
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Stefano Garzarella" <sgarzare@redhat.com>,
	"Dragos Tatulea DE" <dtatulea@nvidia.com>,
	"Cindy Lu" <lulu@redhat.com>,
	"Maxime Coquelin" <mcoqueli@redhat.com>,
	"Eugenio Pérez" <eperezma@redhat.com>,
	"Yongji Xie" <xieyongji@bytedance.com>,
	jasowang@redhat.com, "Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
	linux-kernel@vger.kernel.org,
	"Jonah Palmer" <jonah.palmer@oracle.com>,
	"Si-Wei Liu" <si-wei.liu@oracle.com>,
	virtualization@lists.linux.dev,
	"Beñat Gartzia Arruabarrena" <bgartzia@redhat.com>
Subject: [RFC 1/2] vduse: support feature provisioning
Date: Thu,  2 Oct 2025 12:35:36 +0200	[thread overview]
Message-ID: <20251002103537.308717-2-eperezma@redhat.com> (raw)
In-Reply-To: <20251002103537.308717-1-eperezma@redhat.com>

This patch implements features provisioning for vduse devices.  This
allows the device provisioner to clear the features exposed by the
userland device, so the driver never see them.  The intended use case is
to provision more than one different device with the same feature set,
allowing live migration between them.

The device addition validates the provisioned features to be a subset of
the parent features, as the rest of the backends.

Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
 drivers/vdpa/vdpa_user/vduse_dev.c | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
index 6c74282d5721..ef8fc795cfeb 100644
--- a/drivers/vdpa/vdpa_user/vduse_dev.c
+++ b/drivers/vdpa/vdpa_user/vduse_dev.c
@@ -121,6 +121,7 @@ struct vduse_dev {
 	bool connected;
 	u64 api_version;
 	u64 device_features;
+	u64 supported_features;
 	u64 driver_features;
 	u32 device_id;
 	u32 vendor_id;
@@ -698,7 +699,7 @@ static u64 vduse_vdpa_get_device_features(struct vdpa_device *vdpa)
 {
 	struct vduse_dev *dev = vdpa_to_vduse(vdpa);
 
-	return dev->device_features;
+	return dev->supported_features;
 }
 
 static int vduse_vdpa_set_driver_features(struct vdpa_device *vdpa, u64 features)
@@ -2256,13 +2257,22 @@ struct vduse_mgmt_dev {
 
 static struct vduse_mgmt_dev *vduse_mgmt;
 
-static int vduse_dev_init_vdpa(struct vduse_dev *dev, const char *name)
+static int vduse_dev_init_vdpa(struct vduse_dev *dev, const char *name,
+			       const struct vdpa_dev_set_config *config)
 {
 	struct vduse_vdpa *vdev;
 
 	if (dev->vdev)
 		return -EEXIST;
 
+	if (config->mask & BIT_ULL(VDPA_ATTR_DEV_FEATURES)) {
+		if (config->device_features & ~dev->device_features)
+			return -EINVAL;
+		dev->supported_features = config->device_features;
+	} else {
+		dev->supported_features = dev->device_features;
+	}
+
 	vdev = vdpa_alloc_device(struct vduse_vdpa, vdpa, dev->dev,
 				 &vduse_vdpa_config_ops, &vduse_map_ops,
 				 dev->ngroups, dev->nas, name, true);
@@ -2289,7 +2299,7 @@ static int vdpa_dev_add(struct vdpa_mgmt_dev *mdev, const char *name,
 		mutex_unlock(&vduse_lock);
 		return -EINVAL;
 	}
-	ret = vduse_dev_init_vdpa(dev, name);
+	ret = vduse_dev_init_vdpa(dev, name, config);
 	mutex_unlock(&vduse_lock);
 	if (ret)
 		return ret;
@@ -2376,6 +2386,7 @@ static int vduse_mgmtdev_init(void)
 	vduse_mgmt->mgmt_dev.id_table = id_table;
 	vduse_mgmt->mgmt_dev.ops = &vdpa_dev_mgmtdev_ops;
 	vduse_mgmt->mgmt_dev.device = &vduse_mgmt->dev;
+	vduse_mgmt->mgmt_dev.config_attr_mask = BIT_ULL(VDPA_ATTR_DEV_FEATURES);
 	ret = vdpa_mgmtdev_register(&vduse_mgmt->mgmt_dev);
 	if (ret)
 		device_unregister(&vduse_mgmt->dev);
-- 
2.51.0


  reply	other threads:[~2025-10-02 10:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-02 10:35 [RFC 0/2] support vduse feature provisioning in vdpa netlink command Eugenio Pérez
2025-10-02 10:35 ` Eugenio Pérez [this message]
2025-10-10  4:38   ` [RFC 1/2] vduse: support feature provisioning Si-Wei Liu
2025-10-10  9:41     ` Eugenio Perez Martin
2025-10-02 10:35 ` [RFC 2/2] vduse: allow to specify device-specific features if it's multiclass Eugenio Pérez
2025-10-10  1:39   ` Jason Wang
2025-10-10  3:58     ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251002103537.308717-2-eperezma@redhat.com \
    --to=eperezma@redhat.com \
    --cc=bgartzia@redhat.com \
    --cc=dtatulea@nvidia.com \
    --cc=jasowang@redhat.com \
    --cc=jonah.palmer@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lulu@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mcoqueli@redhat.com \
    --cc=mst@redhat.com \
    --cc=sgarzare@redhat.com \
    --cc=si-wei.liu@oracle.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xieyongji@bytedance.com \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox